Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4132)

Unified Diff: chrome/browser/extensions/external_policy_loader.cc

Issue 11307020: Cleanup: Simplify some extensions / content_settings Observer code by simply DCHECKING instead of u… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Flip DCHECK_EQ arguments to (expected, actual) Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/external_policy_loader.cc
===================================================================
--- chrome/browser/extensions/external_policy_loader.cc (revision 165014)
+++ chrome/browser/extensions/external_policy_loader.cc (working copy)
@@ -82,12 +82,9 @@
switch (type) {
case chrome::NOTIFICATION_PREF_CHANGED: {
if (content::Source<PrefService>(source).ptr() == profile_->GetPrefs()) {
- std::string* pref_name = content::Details<std::string>(details).ptr();
- if (*pref_name == prefs::kExtensionInstallForceList) {
- StartLoading();
- } else {
- NOTREACHED() << "Unexpected preference name.";
- }
+ DCHECK_EQ(std::string(prefs::kExtensionInstallForceList),
+ *content::Details<std::string>(details).ptr());
+ StartLoading();
}
break;
}
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698