chrome/browser/extensions/extension_service.cc - Issue 11307020: Cleanup: Simplify some extensions / content_settings Observer code by simply DCHECKING instead of u…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 11307020: Cleanup: Simplify some extensions / content_settings Observer code by simply DCHECKING instead of u… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Flip DCHECK_EQ arguments to (expected, actual) Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_service.cc

===================================================================

--- chrome/browser/extensions/extension_service.cc (revision 165014)

+++ chrome/browser/extensions/extension_service.cc (working copy)

@@ -2582,14 +2582,13 @@

break;

}

case chrome::NOTIFICATION_PREF_CHANGED: {

- std::string* pref_name = content::Details<std::string>(details).ptr();

- if (*pref_name == prefs::kExtensionInstallAllowList ||

- *pref_name == prefs::kExtensionInstallDenyList) {

- IdentifyAlertableExtensions();

- CheckManagementPolicy();

- } else {

- NOTREACHED() << "Unexpected preference name.";

- }

+ const std::string& pref_name =

+ *content::Details<std::string>(details).ptr();

+ DCHECK(pref_name == prefs::kExtensionInstallAllowList ||

+ pref_name == prefs::kExtensionInstallDenyList)

+ << "Unexpected preference name " << pref_name;

+ IdentifyAlertableExtensions();

+ CheckManagementPolicy();

break;

}

case chrome::NOTIFICATION_IMPORT_FINISHED: {

« no previous file with comments | « chrome/browser/extensions/component_loader.cc ('k') | chrome/browser/extensions/external_policy_loader.cc » ('j') | no next file with comments »