Cleanup: Simplify some extensions / content_settings Observer code by simply DCHECKING instead of u…

chrome/browser/extensions/extension_service.cc

Index: chrome/browser/extensions/extension_service.cc
===================================================================
--- chrome/browser/extensions/extension_service.cc	(revision 164413)
+++ chrome/browser/extensions/extension_service.cc	(working copy)
@@ -2591,14 +2591,12 @@
       break;
     }
     case chrome::NOTIFICATION_PREF_CHANGED: {
-      std::string* pref_name = content::Details<std::string>(details).ptr();
-      if (*pref_name == prefs::kExtensionInstallAllowList ||
-          *pref_name == prefs::kExtensionInstallDenyList) {
-        IdentifyAlertableExtensions();
-        CheckManagementPolicy();
-      } else {
-        NOTREACHED() << "Unexpected preference name.";
-      }
+      const std::string& pref_name =
+          *content::Details<std::string>(details).ptr();
+      DCHECK(pref_name == prefs::kExtensionInstallAllowList ||
+             pref_name == prefs::kExtensionInstallDenyList);

[Yoyo Zhou, 2012/10/27 15:45:03]

You can still emit the NOTREACHED message from the DCHECK.

[Lei Zhang, 2012/10/30 00:01:45]

Done. I will also output |pref_name| so the error message is more useful.

+      IdentifyAlertableExtensions();
+      CheckManagementPolicy();
       break;
     }
     case chrome::NOTIFICATION_IMPORT_FINISHED: {