Cleanup: Simplify some extensions / content_settings Observer code by simply DCHECKING instead of u…

chrome/browser/extensions/external_policy_loader.cc

Index: chrome/browser/extensions/external_policy_loader.cc
===================================================================
--- chrome/browser/extensions/external_policy_loader.cc	(revision 164413)
+++ chrome/browser/extensions/external_policy_loader.cc	(working copy)
@@ -82,12 +82,9 @@
   switch (type) {
     case chrome::NOTIFICATION_PREF_CHANGED: {
       if (content::Source<PrefService>(source).ptr() == profile_->GetPrefs()) {
-        std::string* pref_name = content::Details<std::string>(details).ptr();
-        if (*pref_name == prefs::kExtensionInstallForceList) {
-          StartLoading();
-        } else {
-          NOTREACHED() << "Unexpected preference name.";
-        }
+        DCHECK_EQ(*content::Details<std::string>(details).ptr(),

[Yoyo Zhou, 2012/10/27 15:45:03]

ditto

[Lei Zhang, 2012/10/30 00:01:45]

If the DCHECK_EQ fails, it will print "expected foo, got bar". Emitting the
message is redundant in this case.

+                  std::string(prefs::kExtensionInstallForceList));
+        StartLoading();
       }
       break;
     }