Issue 11307020: Cleanup: Simplify some extensions / content_settings Observer code by simply DCHECKING instead of u…

Issue 11307020: Cleanup: Simplify some extensions / content_settings Observer code by simply DCHECKING instead of u… (Closed)

Created:
8 years, 1 month ago by Lei Zhang

Modified:
8 years, 1 month ago

Reviewers:
Bernhard Bauer, Yoyo Zhou

CC:
chromium-reviews, Aaron Boodman, markusheintz_, chromium-apps-reviews_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Cleanup: Simplify some extensions / content_settings Observer code by simply DCHECKING instead of using if + NOTREACHED(). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165090

Patch Set 4 : Flip DCHECK_EQ arguments to (expected, actual) #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -131 lines)			Patch
M	chrome/browser/content_settings/content_settings_default_provider.cc	View	1 2 3	1 chunk	+20 lines, -23 lines	0 comments	Download
M	chrome/browser/content_settings/content_settings_policy_provider.cc	View	1 2 3	1 chunk	+36 lines, -37 lines	0 comments	Download
M	chrome/browser/content_settings/content_settings_pref_provider.cc	View	1 2 3	1 chunk	+11 lines, -17 lines	0 comments	Download
M	chrome/browser/content_settings/cookie_settings.cc	View	1 2 3	1 chunk	+8 lines, -13 lines	0 comments	Download
M	chrome/browser/extensions/api/font_settings/font_settings_api.cc	View	1 2 3	1 chunk	+7 lines, -10 lines	0 comments	Download
M	chrome/browser/extensions/api/preference/preference_api.cc	View	1 2 3	1 chunk	+3 lines, -7 lines	0 comments	Download
M	chrome/browser/extensions/component_loader.cc	View	1 2 3	1 chunk	+4 lines, -10 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.cc	View	1 2	1 chunk	+7 lines, -8 lines	0 comments	Download
M	chrome/browser/extensions/external_policy_loader.cc	View	1 2 3	1 chunk	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Yoyo Zhou

LGTM https://chromiumcodereview.appspot.com/11307020/diff/1011/chrome/browser/extensions/extension_service.cc File chrome/browser/extensions/extension_service.cc (right): https://chromiumcodereview.appspot.com/11307020/diff/1011/chrome/browser/extensions/extension_service.cc#newcode2597 chrome/browser/extensions/extension_service.cc:2597: pref_name == prefs::kExtensionInstallDenyList); You can still emit the ...

8 years, 1 month ago (2012-10-27 15:45:03 UTC) #3

Lei Zhang

https://chromiumcodereview.appspot.com/11307020/diff/1011/chrome/browser/extensions/extension_service.cc File chrome/browser/extensions/extension_service.cc (right): https://chromiumcodereview.appspot.com/11307020/diff/1011/chrome/browser/extensions/extension_service.cc#newcode2597 chrome/browser/extensions/extension_service.cc:2597: pref_name == prefs::kExtensionInstallDenyList); On 2012/10/27 15:45:03, Yoyo Zhou wrote: ...

8 years, 1 month ago (2012-10-30 00:01:45 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/11307020/28001

8 years, 1 month ago (2012-10-30 22:50:45 UTC) #5

Change committed as 165090

Expand Messages | Collapse Messages