Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: extension/background.html

Issue 11305009: Fix dwc extension with latest js-interop, small fix to dwc, and updates to (Closed) Base URL: git@github.com:dart-lang/dart-web-components.git@master
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « example/explainer/build_examples.dart ('k') | extension/dart_proxy.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extension/background.html
diff --git a/extension/background.html b/extension/background.html
index 3287d1ea6aa45eb4fb5e0d8b972622ca9c1823c7..ad0c3b409d93c1e83db124567c975c9612fc2857 100644
--- a/extension/background.html
+++ b/extension/background.html
@@ -3,10 +3,10 @@
<script type="application/dart" src="bin/dwc_browser.dart"></script>
<script type="text/javascript" src="dart.js"></script>
<!--
- TODO(jacobr): this is a hack to make Dart-JS interop work given chrome
- extension security restrictions for inline JS
+ We must load 'dart_interop.js' explicitly. It cannot be injected dynamically
Jennifer Messerly 2012/10/26 18:56:26 do we still need this comment? I thought dart_inte
Siggi Cherem (dart-lang) 2012/10/26 19:01:36 you are correct, I just wanted to keep some messag
+ because of security restrictions for inline JS on chrome extensions.
-->
- <script src="dart_proxy.js"></script>
+ <script src="bin/packages/js/dart_interop.js"></script>
<script src="background.js"></script>
</head>
<body>
« no previous file with comments | « example/explainer/build_examples.dart ('k') | extension/dart_proxy.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698