Issue 11305009: Fix dwc extension with latest js-interop, small fix to dwc, and updates to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11305009: Fix dwc extension with latest js-interop, small fix to dwc, and updates to (Closed)

Created:
8 years, 1 month ago by Siggi Cherem (dart-lang)

Modified:
8 years, 1 month ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dart-web-components.git@master

Visibility:
Public.

More Reviews

Description

Fix dwc extension with latest js-interop, small fix to dwc, and updates to latest sdk. Committed: https://github.com/dart-lang/dart-web-components/commit/56fcbbe

Patch Set 1 #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -496 lines)			Patch
M	bin/dwc_browser.dart	View	1 chunk	+5 lines, -6 lines	0 comments	Download
M	example/explainer/build_examples.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extension/background.html	View	1 chunk	+3 lines, -3 lines	2 comments	Download
D	extension/dart_proxy.js	View	1 chunk	+0 lines, -482 lines	0 comments	Download
M	lib/src/compiler.dart	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	lib/src/utils.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

lgtm https://chromiumcodereview.appspot.com/11305009/diff/1/extension/background.html File extension/background.html (right): https://chromiumcodereview.appspot.com/11305009/diff/1/extension/background.html#newcode6 extension/background.html:6: We must load 'dart_interop.js' explicitly. It cannot be ...

8 years, 1 month ago (2012-10-26 18:56:26 UTC) #2

Siggi Cherem (dart-lang)

8 years, 1 month ago (2012-10-26 19:01:36 UTC) #3

https://chromiumcodereview.appspot.com/11305009/diff/1/extension/background.html
File extension/background.html (right):

https://chromiumcodereview.appspot.com/11305009/diff/1/extension/background.h...
extension/background.html:6: We must load 'dart_interop.js' explicitly. It
cannot be injected dynamically
On 2012/10/26 18:56:26, John Messerly wrote:
> do we still need this comment? I thought dart_interop.js is explicitly
required
> now -- but I could be misremembering :)

you are correct, I just wanted to keep some message that reminds us about the
chrome extension security restrictions...

Expand Messages | Collapse Messages