extension/background.html - Issue 11305009: Fix dwc extension with latest js-interop, small fix to dwc, and updates to

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extension/background.html

Issue 11305009: Fix dwc extension with latest js-interop, small fix to dwc, and updates to (Closed) Base URL: git@github.com:dart-lang/dart-web-components.git@master

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script type="application/dart" src="bin/dwc_browser.dart"></script>	3 <script type="application/dart" src="bin/dwc_browser.dart"></script>

4 <script type="text/javascript" src="dart.js"></script>	4 <script type="text/javascript" src="dart.js"></script>

5 <!--	5 <!--

6 TODO(jacobr): this is a hack to make Dart-JS interop work given chrome	6 We must load 'dart_interop.js' explicitly. It cannot be injected dynamically
	Jennifer Messerly 2012/10/26 18:56:26 do we still need this comment? I thought dart_inte do we still need this comment? I thought dart_interop.js is explicitly required now -- but I could be misremembering :) Siggi Cherem (dart-lang) 2012/10/26 19:01:36 you are correct, I just wanted to keep some messag Show quoted text On 2012/10/26 18:56:26, John Messerly wrote: > do we still need this comment? I thought dart_interop.js is explicitly required > now -- but I could be misremembering :) you are correct, I just wanted to keep some message that reminds us about the chrome extension security restrictions...
7 extension security restrictions for inline JS	7 because of security restrictions for inline JS on chrome extensions.

8 -->	8 -->

9 <script src="dart_proxy.js"></script>	9 <script src="bin/packages/js/dart_interop.js"></script>

10 <script src="background.js"></script>	10 <script src="background.js"></script>

11 </head>	11 </head>

12 <body>	12 <body>

13 </body>	13 </body>

14 </html>	14 </html>

OLD	NEW

« no previous file with comments | « example/explainer/build_examples.dart ('k') | extension/dart_proxy.js » ('j') | no next file with comments »