Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 1130063003: Convert master_manager_launcher to use multiprocessing. (Closed)

Created:
5 years, 7 months ago by ghost stip (do not use)
Modified:
5 years, 7 months ago
Reviewers:
iannucci, agable, pgervais
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/infra.git@master-kickoff
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase onto latest master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -9 lines) Patch
A + infra/libs/process_invocation/__init__.py View 1 1 chunk +0 lines, -3 lines 0 comments Download
A infra/libs/process_invocation/multiprocess.py View 1 chunk +57 lines, -0 lines 0 comments Download
A + infra/libs/process_invocation/test/__init__.py View 1 1 chunk +0 lines, -3 lines 0 comments Download
A infra/libs/process_invocation/test/multiprocess_test.py View 1 chunk +48 lines, -0 lines 0 comments Download
M infra/services/master_manager_launcher/__main__.py View 1 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ghost stip (do not use)
ptal (although it's based on a still-being-reviewed CL)
5 years, 7 months ago (2015-05-06 23:49:20 UTC) #2
iannucci
ugh multiprocessing... 'lgtm'
5 years, 7 months ago (2015-05-06 23:54:08 UTC) #3
pgervais
On 2015/05/06 23:54:08, iannucci wrote: > ugh multiprocessing... 'lgtm' lgtm though you should put something ...
5 years, 7 months ago (2015-05-07 00:04:54 UTC) #4
ghost stip (do not use)
what
5 years, 7 months ago (2015-05-07 00:55:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130063003/20001
5 years, 7 months ago (2015-05-08 00:55:57 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 01:00:05 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/6bc59cdf67bfc54f8fe67de7da9cd...

Powered by Google App Engine
This is Rietveld 408576698