Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11299270: Add a parameter that specifies whether onKeyEvent is asynchronous (Closed)

Created:
8 years ago by Zachary Kuznia
Modified:
8 years ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Add a parameter that specifies whether onKeyEvent is asynchronous BUG=159981 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170714

Patch Set 1 #

Patch Set 2 : Revert extra file #

Patch Set 3 : Remove extra function #

Total comments: 2

Patch Set 4 : Code review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -18 lines) Patch
M chrome/browser/extensions/api/input_ime/input_ime_api.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_function_registry.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/extensions/api/input_ime.json View 1 2 3 2 chunks +18 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/input.ime_custom_bindings.js View 1 2 3 1 chunk +14 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Zachary Kuznia
I've added a flag that specifies if the onKeyEvent listener is asynchronous. This is completely ...
8 years ago (2012-11-30 04:48:14 UTC) #1
Matt Perry
https://codereview.chromium.org/11299270/diff/2001/chrome/renderer/resources/extensions/input.ime_custom_bindings.js File chrome/renderer/resources/extensions/input.ime_custom_bindings.js (right): https://codereview.chromium.org/11299270/diff/2001/chrome/renderer/resources/extensions/input.ime_custom_bindings.js#newcode26 chrome/renderer/resources/extensions/input.ime_custom_bindings.js:26: if (!this.eventOptions_.supportsListeners) Rather than cut+pasting, you can call the ...
8 years ago (2012-11-30 20:31:59 UTC) #2
Matt Perry
LGTM after addressing comments.
8 years ago (2012-11-30 20:32:25 UTC) #3
Zachary Kuznia
https://codereview.chromium.org/11299270/diff/2001/chrome/renderer/resources/extensions/input.ime_custom_bindings.js File chrome/renderer/resources/extensions/input.ime_custom_bindings.js (right): https://codereview.chromium.org/11299270/diff/2001/chrome/renderer/resources/extensions/input.ime_custom_bindings.js#newcode26 chrome/renderer/resources/extensions/input.ime_custom_bindings.js:26: if (!this.eventOptions_.supportsListeners) On 2012/11/30 20:31:59, Matt Perry wrote: > ...
8 years ago (2012-12-03 05:54:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/11299270/3006
8 years ago (2012-12-03 05:54:58 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-03 08:34:11 UTC) #6
Message was sent while issue was closed. 
Change committed as 170714

Powered by Google App Engine
This is Rietveld 408576698