Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8051)

Unified Diff: chrome/common/extensions/api/input_ime.json

Issue 11299270: Add a parameter that specifies whether onKeyEvent is asynchronous (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Code review fix Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/input_ime.json
diff --git a/chrome/common/extensions/api/input_ime.json b/chrome/common/extensions/api/input_ime.json
index 51b0cbfa131e16d243b87c58acc7aa9b90bd7c24..99c9c5e3e4132cc00cc16c0a7ec3a0306a03a851 100644
--- a/chrome/common/extensions/api/input_ime.json
+++ b/chrome/common/extensions/api/input_ime.json
@@ -403,13 +403,12 @@
]
},
{
- "name": "eventHandled",
- "nodoc": true,
+ "name": "keyEventHandled",
"type": "function",
- "description": "Used internally to send a response for onKeyEvent.",
+ "description": "Indicates that the key event received by onKeyEvent is handled. This should only be called if the onKeyEvent listener is asynchronous.",
"parameters": [
- {"type": "string", "name": "requestId"},
- {"type": "boolean", "name": "response"}
+ {"type": "string", "name": "requestId", "description": "Request id of the event that was handled. This should come from keyEvent.requestId"},
+ {"type": "boolean", "name": "response", "description": "True if the keystroke was handled, false if not"}
]
}
],
@@ -496,9 +495,22 @@
"description": "Data on the key event"
}
],
+ "extraParameters": [
+ {
+ "type": "array",
+ "optional": true,
+ "name": "extraInfoSpec",
+ "description": "Array of extra information that should be passed to the listener function.",
+ "items": {
+ "type": "string",
+ "enum": ["async"]
+ }
+ }
+ ],
"returns": {
"type": "boolean",
- "description": "True if the keystroke was handled, false if not"
+ "description": "True if the keystroke was handled, false if not",
+ "optional": true
}
},
{

Powered by Google App Engine
This is Rietveld 408576698