Issue 11299213: Do not include memory referenced by locals and other stack memory to the dump. This memory is valua…

Issue 11299213: Do not include memory referenced by locals and other stack memory to the dump. This memory is valua… (Closed)

Created:
8 years ago by alexeypa (please no reviews)

Modified:
8 years ago

Reviewers:
Wez, Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Do not include memory referenced by locals and other stack memory to the dump. This memory is valuable during debugging but it increases size of minidumps beyond the accepted limit. The result is the dumps are not processed at all and we don't get any information. BUG=162914 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=169963

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	remoting/base/breakpad_win.cc	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/11299213/1

8 years ago (2012-11-27 18:56:43 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

8 years ago (2012-11-27 20:01:46 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/11299213/1

8 years ago (2012-11-27 22:51:05 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/11299213/1

8 years ago (2012-11-28 15:03:56 UTC) #6

Message was sent while issue was closed.

Change committed as 169963

Expand Messages | Collapse Messages