Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: remoting/base/breakpad_win.cc

Issue 11299213: Do not include memory referenced by locals and other stack memory to the dump. This memory is valua… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/base/breakpad_win.cc
diff --git a/remoting/base/breakpad_win.cc b/remoting/base/breakpad_win.cc
index ef16a24048c881ecd93ddcc4da125fc0d5bba099..d083ceed64a4e4ac5d8f4e95b2ab0d0f205d0949 100644
--- a/remoting/base/breakpad_win.cc
+++ b/remoting/base/breakpad_win.cc
@@ -112,12 +112,10 @@ BreakpadWin::BreakpadWin() : handling_exception_(0) {
if (length == 0)
return;
- // Minidump with stacks, PEB, TEB, unloaded module list and memory referenced
- // from stack.
+ // Minidump with stacks, PEB, TEBs and unloaded module list.
MINIDUMP_TYPE dump_type = static_cast<MINIDUMP_TYPE>(
MiniDumpWithProcessThreadData |
- MiniDumpWithUnloadedModules |
- MiniDumpWithIndirectlyReferencedMemory);
+ MiniDumpWithUnloadedModules);
breakpad_.reset(
new google_breakpad::ExceptionHandler(
temp_directory, &OnExceptionCallback, NULL, NULL,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698