Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 11299038: Return first_run_win to using the Chrome path provider to look up the user data dir. (Closed)

Created:
8 years, 1 month ago by robertshield
Modified:
8 years, 1 month ago
Reviewers:
sky, grt (UTC plus 2)
CC:
chromium-reviews
Visibility:
Public.

Description

Return first_run_win to using the Chrome path provider to look up the user data dir. This changed in https://chromiumcodereview.appspot.com/10837222/ which causes a regression when the user data dir is overridden via GP. BUG=161336 TEST=Have a group policy set to move the user data dir elsewhere. Ensure that repeated Chrome launches do not go through the first run flow. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168531

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M chrome/browser/first_run/first_run_internal.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/first_run/first_run_win.cc View 1 2 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
grt (UTC plus 2)
lgtm
8 years, 1 month ago (2012-11-16 18:31:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/11299038/2001
8 years, 1 month ago (2012-11-16 20:44:37 UTC) #2
commit-bot: I haz the power
Presubmit check for 11299038-2001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 1 month ago (2012-11-16 20:44:41 UTC) #3
robertshield
+sky for owners
8 years, 1 month ago (2012-11-16 20:59:48 UTC) #4
sky
LGTM
8 years, 1 month ago (2012-11-16 22:23:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/11299038/2001
8 years, 1 month ago (2012-11-16 22:42:38 UTC) #6
commit-bot: I haz the power
Retried try job too often for step(s) interactive_ui_tests
8 years, 1 month ago (2012-11-16 23:50:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/11299038/2001
8 years, 1 month ago (2012-11-19 14:57:53 UTC) #8
commit-bot: I haz the power
8 years, 1 month ago (2012-11-19 15:25:50 UTC) #9
Change committed as 168531

Powered by Google App Engine
This is Rietveld 408576698