Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Issue 11299023: Add real support for uint128. (Closed)

Created:
8 years, 1 month ago by Ryan Hamilton
Modified:
8 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Add real support for uint128. These files originated with google internally, and since they are shared, the style is a bit different. Removed SWIG support and references to other internal classes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168161

Patch Set 1 #

Patch Set 2 : Sort headers #

Patch Set 3 : fix comments #

Patch Set 4 : NET_EXPORT_PRIVATE #

Patch Set 5 : One more try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+623 lines, -58 lines) Patch
A net/base/int128.h View 1 2 3 4 1 chunk +330 lines, -0 lines 0 comments Download
A net/base/int128.cc View 1 chunk +16 lines, -0 lines 0 comments Download
A net/base/int128_unittest.cc View 1 chunk +265 lines, -0 lines 0 comments Download
M net/net.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/crypto/null_decrypter_test.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M net/quic/crypto/null_encrypter_test.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M net/quic/quic_data_reader.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_data_writer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_data_writer.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M net/quic/quic_protocol.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_utils.h View 1 1 chunk +1 line, -1 line 0 comments Download
D net/quic/uint128.h View 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ryan Hamilton
8 years, 1 month ago (2012-11-16 00:30:51 UTC) #1
willchan no longer on Chromium
lgtm with offline comments about updating the changelist description to eliminate google3 and swig references
8 years, 1 month ago (2012-11-16 00:38:30 UTC) #2
Ryan Hamilton
On 2012/11/16 00:38:30, willchan wrote: > lgtm with offline comments about updating the changelist description ...
8 years, 1 month ago (2012-11-16 00:40:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/11299023/11001
8 years, 1 month ago (2012-11-16 00:57:24 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-11-16 01:20:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/11299023/2004
8 years, 1 month ago (2012-11-16 03:57:09 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-11-16 04:27:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/11299023/29
8 years, 1 month ago (2012-11-16 05:22:58 UTC) #8
commit-bot: I haz the power
8 years, 1 month ago (2012-11-16 07:49:46 UTC) #9
Change committed as 168161

Powered by Google App Engine
This is Rietveld 408576698