Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 11293285: Fixes #163 - small fix in the mangling logic, renames all expected test files (Closed)

Created:
8 years, 1 month ago by Siggi Cherem (dart-lang)
Modified:
8 years, 1 month ago
Reviewers:
justinfagnani
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dart-web-components.git@master
Visibility:
Public.

Description

Fixes #163 - small fix in the mangling logic, renames all expected test files that now don't use mangling. Committed: https://github.com/dart-lang/dart-web-components/commit/6c41469

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+-48 lines, -2080 lines) Patch
M lib/src/compiler.dart View 1 2 chunks +1 line, -2 lines 2 comments Download
M lib/src/info.dart View 1 1 chunk +4 lines, -1 line 0 comments Download
A + test/data/expected/attr_multiple_bindings_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/attr_multiple_bindings_test.html.html.txt View 1 chunk +0 lines, -38 lines 0 comments Download
A + test/data/expected/bind_hyphenated_attribute_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/bind_hyphenated_attribute_test.html.html.txt View 1 chunk +0 lines, -13 lines 0 comments Download
A + test/data/expected/code_in_dart_file_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/code_in_dart_file_test.html.html.txt View 1 chunk +0 lines, -15 lines 0 comments Download
A + test/data/expected/component_imports_component2_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/component_imports_component2_test.html.html.txt View 1 chunk +0 lines, -21 lines 0 comments Download
A + test/data/expected/component_imports_component3_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/component_imports_component3_test.html.html.txt View 1 chunk +0 lines, -39 lines 0 comments Download
A + test/data/expected/component_imports_component_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/component_imports_component_test.html.html.txt View 1 chunk +0 lines, -21 lines 0 comments Download
A + test/data/expected/component_in_main_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/component_in_main_test.html.html.txt View 1 chunk +0 lines, -15 lines 0 comments Download
A + test/data/expected/component_inherit_noscript_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/component_inherit_noscript_test.html.html.txt View 1 chunk +0 lines, -28 lines 0 comments Download
A + test/data/expected/component_inherit_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/component_inherit_test.html.html.txt View 1 chunk +0 lines, -27 lines 0 comments Download
A + test/data/expected/conditional2_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/conditional2_test.html.html.txt View 1 chunk +0 lines, -14 lines 0 comments Download
A + test/data/expected/conditional3_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/conditional3_test.html.html.txt View 1 chunk +0 lines, -14 lines 0 comments Download
A + test/data/expected/conditional4_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/conditional4_test.html.html.txt View 1 chunk +0 lines, -17 lines 0 comments Download
A + test/data/expected/conditional5_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/conditional5_test.html.html.txt View 1 chunk +0 lines, -15 lines 0 comments Download
A + test/data/expected/conditional_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/conditional_test.html.html.txt View 1 chunk +0 lines, -13 lines 0 comments Download
A + test/data/expected/css_classes_binding_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/css_classes_binding_test.html.html.txt View 1 chunk +0 lines, -18 lines 0 comments Download
A + test/data/expected/data_style_binding_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/data_style_binding_test.html.html.txt View 1 chunk +0 lines, -12 lines 0 comments Download
A + test/data/expected/data_value_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/data_value_test.html.html.txt View 1 chunk +0 lines, -53 lines 0 comments Download
A + test/data/expected/dom_accessor_binding2_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/dom_accessor_binding2_test.html.html.txt View 1 chunk +0 lines, -16 lines 0 comments Download
A + test/data/expected/dom_accessor_binding_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/dom_accessor_binding_test.html.html.txt View 1 chunk +0 lines, -20 lines 0 comments Download
A + test/data/expected/duplicate_event_listeners_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/duplicate_event_listeners_test.html.html.txt View 1 chunk +0 lines, -22 lines 0 comments Download
A + test/data/expected/empty_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/empty_test.html.html.txt View 1 chunk +0 lines, -13 lines 0 comments Download
A + test/data/expected/escape2_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/escape2_test.html.html.txt View 1 chunk +0 lines, -33 lines 0 comments Download
A + test/data/expected/escape_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/escape_test.html.html.txt View 1 chunk +0 lines, -20 lines 0 comments Download
A + test/data/expected/html_escape_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/html_escape_test.html.html.txt View 1 chunk +0 lines, -27 lines 0 comments Download
A + test/data/expected/if_attribute_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/if_attribute_test.html.html.txt View 1 chunk +0 lines, -12 lines 0 comments Download
A + test/data/expected/if_children_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/if_children_test.html.html.txt View 1 chunk +0 lines, -36 lines 0 comments Download
A + test/data/expected/if_fragments2_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/if_fragments2_test.html.html.txt View 1 chunk +0 lines, -19 lines 0 comments Download
A + test/data/expected/if_fragments3_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/if_fragments3_test.html.html.txt View 1 chunk +0 lines, -21 lines 0 comments Download
A + test/data/expected/if_fragments_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/if_fragments_test.html.html.txt View 1 chunk +0 lines, -18 lines 0 comments Download
A + test/data/expected/iterate_attribute_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/iterate_attribute_test.html.html.txt View 1 chunk +0 lines, -22 lines 0 comments Download
A + test/data/expected/iterate_fragments_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/iterate_fragments_test.html.html.txt View 1 chunk +0 lines, -170 lines 0 comments Download
A + test/data/expected/list2_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/list2_test.html.html.txt View 1 chunk +0 lines, -16 lines 0 comments Download
A + test/data/expected/list3_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/list3_test.html.html.txt View 1 chunk +0 lines, -30 lines 0 comments Download
A + test/data/expected/list4_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/list4_test.html.html.txt View 1 chunk +0 lines, -33 lines 0 comments Download
A + test/data/expected/list_children_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/list_children_test.html.html.txt View 1 chunk +0 lines, -48 lines 0 comments Download
A + test/data/expected/list_component_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/list_component_test.html.html.txt View 1 chunk +0 lines, -19 lines 0 comments Download
A + test/data/expected/list_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/list_test.html.html.txt View 1 chunk +0 lines, -16 lines 0 comments Download
A + test/data/expected/main_code_in_dart_file_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/main_code_in_dart_file_test.html.html.txt View 1 chunk +0 lines, -14 lines 0 comments Download
A + test/data/expected/mix_iterate_if_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/mix_iterate_if_test.html.html.txt View 1 chunk +0 lines, -38 lines 0 comments Download
A + test/data/expected/news_index_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/news_index_test.html.html.txt View 1 chunk +0 lines, -53 lines 0 comments Download
A + test/data/expected/path_normalization_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/path_normalization_test.html.html.txt View 1 chunk +0 lines, -26 lines 0 comments Download
A + test/data/expected/table_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/table_test.html.html.txt View 1 chunk +0 lines, -51 lines 0 comments Download
A + test/data/expected/template_multiple_children_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/template_multiple_children_test.html.html.txt View 1 chunk +0 lines, -16 lines 0 comments Download
A + test/data/expected/template_zero_children_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/template_zero_children_test.html.html.txt View 1 chunk +0 lines, -14 lines 0 comments Download
A + test/data/expected/text_multiple_bindings_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/text_multiple_bindings_test.html.html.txt View 1 chunk +0 lines, -33 lines 0 comments Download
A + test/data/expected/text_top_level2_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/text_top_level2_test.html.html.txt View 1 chunk +0 lines, -15 lines 0 comments Download
A + test/data/expected/text_top_level_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/text_top_level_test.html.html.txt View 1 chunk +0 lines, -14 lines 0 comments Download
A + test/data/expected/todomvc_listorder_shadowdom_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/todomvc_listorder_shadowdom_test.html.html.txt View 1 chunk +0 lines, -193 lines 0 comments Download
A + test/data/expected/todomvc_listorder_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/todomvc_listorder_test.html.html.txt View 1 chunk +0 lines, -193 lines 0 comments Download
A + test/data/expected/todomvc_mainpage2_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/todomvc_mainpage2_test.html.html.txt View 1 chunk +0 lines, -145 lines 0 comments Download
A + test/data/expected/todomvc_mainpage_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/todomvc_mainpage_test.html.html.txt View 1 chunk +0 lines, -89 lines 0 comments Download
A + test/data/expected/todomvc_markdone_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/todomvc_markdone_test.html.html.txt View 1 chunk +0 lines, -213 lines 0 comments Download
A + test/data/expected/watch_global_var2_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/watch_global_var2_test.html.html.txt View 1 chunk +0 lines, -12 lines 0 comments Download
A + test/data/expected/watch_global_var3_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/watch_global_var3_test.html.html.txt View 1 chunk +0 lines, -12 lines 0 comments Download
A + test/data/expected/watch_global_var_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/data/expected/watch_global_var_test.html.html.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M test/run.sh View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
mainly only compiler.dart, info.dart, and run.sh have changes. All the expectation files are just renamed. ...
8 years, 1 month ago (2012-11-14 22:01:31 UTC) #1
justinfagnani
lgtm https://chromiumcodereview.appspot.com/11293285/diff/2001/lib/src/compiler.dart File lib/src/compiler.dart (left): https://chromiumcodereview.appspot.com/11293285/diff/2001/lib/src/compiler.dart#oldcode63 lib/src/compiler.dart:63: var _mangleFilenames = basePath != outputPath; On 2012/11/14 ...
8 years, 1 month ago (2012-11-14 22:07:13 UTC) #2
Siggi Cherem (dart-lang)
8 years, 1 month ago (2012-11-14 22:12:46 UTC) #3
On 2012/11/14 22:07:13, justinfagnani wrote:
> lgtm
> 
>
https://chromiumcodereview.appspot.com/11293285/diff/2001/lib/src/compiler.dart
> File lib/src/compiler.dart (left):
> 
>
https://chromiumcodereview.appspot.com/11293285/diff/2001/lib/src/compiler.da...
> lib/src/compiler.dart:63: var _mangleFilenames = basePath != outputPath;
> On 2012/11/14 22:01:31, Siggi Cherem (dart-lang) wrote:
> > I just realized this should be == instead of !=, and should be checked after
> we
> > normalize paths (basically in line 82), when I saw that, it made sense to
hide
> > it under the PathInfo constructor.
> 
> d'oh. the tests don't cover both mangling and no-mangling cases yet, so this
> passed. should we cover both?

good idea - will do. For now I'll submit this fix to get things in a working
state (we might overwrite files in the input dir if --out is omitted in the
current form)

Powered by Google App Engine
This is Rietveld 408576698