Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Unified Diff: lib/src/compiler.dart

Issue 11293285: Fixes #163 - small fix in the mangling logic, renames all expected test files (Closed) Base URL: git@github.com:dart-lang/dart-web-components.git@master
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/src/info.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/compiler.dart
diff --git a/lib/src/compiler.dart b/lib/src/compiler.dart
index 3eae24d8fbbf2f9898ef632d54a10185060087bf..3282028b6d2d39349c1e39b7330254de8f73215c 100644
--- a/lib/src/compiler.dart
+++ b/lib/src/compiler.dart
@@ -60,7 +60,6 @@ class Compiler {
options.baseDir != null ? new Path(options.baseDir) : mainDir;
var outputPath =
options.outputDir != null ? new Path(options.outputDir) : mainDir;
- var _mangleFilenames = basePath != outputPath;
Siggi Cherem (dart-lang) 2012/11/14 22:01:31 I just realized this should be == instead of !=, a
justinfagnani 2012/11/14 22:07:13 d'oh. the tests don't cover both mangling and no-m
// Normalize paths - all should be relative or absolute paths.
bool anyAbsolute = _mainPath.isAbsolute || basePath.isAbsolute ||
@@ -79,7 +78,7 @@ class Compiler {
if (!basePath.isAbsolute) basePath = currentPath.join(basePath);
if (!outputPath.isAbsolute) outputPath = currentPath.join(outputPath);
}
- _pathInfo = new PathInfo(basePath, outputPath, _mangleFilenames);
+ _pathInfo = new PathInfo(basePath, outputPath);
}
/** Compile the application starting from the given [mainFile]. */
« no previous file with comments | « no previous file | lib/src/info.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698