Put the pop-up app launcher behind a compile-time flag, and provide defines.

Put the app launcher on windows/chromeos behind a compile-time flag, and provide defines.

This change decouples the logic that associates the app launcher and
settings app with windows-only builds, and consolidates the list of
app_list sources in chrome_browser_ui.gypi.

BUG=160839
TEST=on Windows: compiles with -Denable_app_list=0 (with no app launcher function), and
     on Windows: compiles with -Denable_settings_app=0 (with app launcher but no settings app in it)
     on ChromeOS: compiles (functional ChromeOS launcher)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167853

[tapted, 2012-11-14 12:27:29]

I've verified the various build configurations in TESTs and checked for breakage
- all good.

[sky, 2012-11-14 15:54:57]

https://chromiumcodereview.appspot.com/11293267/diff/2002/chrome/browser/ui/a...
File chrome/browser/ui/app_list/app_list_controller.cc (right):

https://chromiumcodereview.appspot.com/11293267/diff/2002/chrome/browser/ui/a...
chrome/browser/ui/app_list/app_list_controller.cc:10:
AppListControllerDelegate::~AppListControllerDelegate() {}
Why do we even compile this file when !ENABLE_APP_LIST ?

https://chromiumcodereview.appspot.com/11293267/diff/2002/chrome/chrome_brows...
File chrome/chrome_browser_ui.gypi (right):

https://chromiumcodereview.appspot.com/11293267/diff/2002/chrome/chrome_brows...
chrome/chrome_browser_ui.gypi:2743:
'browser/ui/app_list/app_list_view_delegate.cc',
How come we don't do the normal pattern of listing the files with all other
files and excluding where not appropriate? See comment on line 67.

[tapted, 2012-11-14 22:35:36]

I've put up an alternative that #ifdef-s out parts in 

https://chromiumcodereview.appspot.com/11293267/diff/13037/chrome/browser/ui/...

PTAL.

https://chromiumcodereview.appspot.com/11293267/diff/2002/chrome/browser/ui/a...
File chrome/browser/ui/app_list/app_list_controller.cc (right):

https://chromiumcodereview.appspot.com/11293267/diff/2002/chrome/browser/ui/a...
chrome/browser/ui/app_list/app_list_controller.cc:10:
AppListControllerDelegate::~AppListControllerDelegate() {}
On 2012/11/14 15:54:57, sky wrote:
> Why do we even compile this file when !ENABLE_APP_LIST ?

It was used unconditionally in startup_browser_creator_impl.cc, but it's easy to
#ifdef out now without cluttering things up (done).

https://chromiumcodereview.appspot.com/11293267/diff/2002/chrome/chrome_brows...
File chrome/chrome_browser_ui.gypi (right):

https://chromiumcodereview.appspot.com/11293267/diff/2002/chrome/chrome_brows...
chrome/chrome_browser_ui.gypi:2743:
'browser/ui/app_list/app_list_view_delegate.cc',
On 2012/11/14 15:54:57, sky wrote:
> How come we don't do the normal pattern of listing the files with all other
> files and excluding where not appropriate? See comment on line 67.

I flip-flopped around this a bit in earlier patchsets, since it wasn't the prior
method for app_list.. But with changes to startup_browser_creator_impl.cc the
excludes are much cleaner, so I'm fully sold. Done.

[sky, 2012-11-14 23:24:27]

LGTM

[Evan Stade, 2012-11-14 23:30:51]

lgtm, thanks

[commit-bot: I haz the power, 2012-11-15 00:29:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tapted@chromium.org/11293267/13037

[commit-bot: I haz the power, 2012-11-15 03:58:17]

Change committed as 167853