Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: chrome/browser/ui/app_list/app_list_controller.cc

Issue 11293267: Put the pop-up app launcher behind a compile-time flag, and provide defines. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: prevailing style Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/app_list/app_list_controller.h" 5 #include "chrome/browser/ui/app_list/app_list_controller.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 9
10 AppListControllerDelegate::~AppListControllerDelegate() {} 10 AppListControllerDelegate::~AppListControllerDelegate() {}
sky 2012/11/14 15:54:57 Why do we even compile this file when !ENABLE_APP_
tapted 2012/11/14 22:35:37 It was used unconditionally in startup_browser_cre
11 11
12 void AppListControllerDelegate::ViewClosing() {} 12 void AppListControllerDelegate::ViewClosing() {}
13 13
14 void AppListControllerDelegate::ViewActivationChanged(bool active) {} 14 void AppListControllerDelegate::ViewActivationChanged(bool active) {}
15 15
16 bool AppListControllerDelegate::IsAppPinned(const std::string& extension_id) { 16 bool AppListControllerDelegate::IsAppPinned(const std::string& extension_id) {
17 return false; 17 return false;
18 } 18 }
19 19
20 void AppListControllerDelegate::PinApp(const std::string& extension_id) {} 20 void AppListControllerDelegate::PinApp(const std::string& extension_id) {}
21 21
22 void AppListControllerDelegate::UnpinApp(const std::string& extension_id) {} 22 void AppListControllerDelegate::UnpinApp(const std::string& extension_id) {}
23 23
24 void AppListControllerDelegate::ShowCreateShortcutsDialog( 24 void AppListControllerDelegate::ShowCreateShortcutsDialog(
25 Profile* profile, 25 Profile* profile,
26 const std::string& extension_id) {} 26 const std::string& extension_id) {}
27 27
28 void AppListControllerDelegate::CreateNewWindow(bool incognito) { 28 void AppListControllerDelegate::CreateNewWindow(bool incognito) {
29 NOTREACHED(); 29 NOTREACHED();
30 } 30 }
31 31
32 namespace app_list_controller { 32 namespace app_list_controller {
33 33
34 #if !defined(OS_WIN) 34 #if !defined(ENABLE_APP_LIST) || defined(OS_CHROMEOS)
35 // Default implementation for ports which do not have this implemented. 35 // Default implementation for ports which do not have this implemented.
36 void ShowAppList() {} 36 void ShowAppList() {}
37 37
38 // Default implementation for ports which do not have this implemented. 38 // Default implementation for ports which do not have this implemented.
39 void CheckAppListTaskbarShortcut() {} 39 void CheckAppListTaskbarShortcut() {}
40 #endif 40 #endif
41 41
42 } // namespace app_list_controller 42 } // namespace app_list_controller
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698