Issue 11293241: Cleaning up the custom dictionary code relative to the SpellcheckService to make the custom diction…

Issue 11293241: Cleaning up the custom dictionary code relative to the SpellcheckService to make the custom diction… (Closed)

Created:
8 years, 1 month ago by rpetterson

Modified:
8 years, 1 month ago

Reviewers:
please use gerrit instead, brettw, sky

CC:
chromium-reviews, groby+spellwatch_chromium.org, rpetterson, creis+watch_chromium.org, Avi (use Gerrit), ajwong+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Cleaning up the custom dictionary code relative to the SpellcheckService to make the custom dictionary a bit more encapsulated. This change also moves all the custom dictionary tests into their own unittest suite. BUG=160660 TBR=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167541

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+195 lines, -162 lines)			Patch
M	chrome/browser/spellchecker/spellcheck_custom_dictionary.h	View	3 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/spellchecker/spellcheck_custom_dictionary.cc	View	3 chunks	+27 lines, -1 line	0 comments	Download
A	chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc	View	1 chunk	+154 lines, -0 lines	0 comments	Download
M	chrome/browser/spellchecker/spellcheck_service.h	View	2 chunks	+0 lines, -22 lines	0 comments	Download
M	chrome/browser/spellchecker/spellcheck_service.cc	View	2 chunks	+0 lines, -41 lines	0 comments	Download
M	chrome/browser/spellchecker/spellcheck_service_unittest.cc	View	1 chunk	+0 lines, -97 lines	0 comments	Download
M	chrome/browser/tab_contents/spelling_menu_observer.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

rpetterson

rouslan - custom dictionary/spellcheck brettw - tab_contents sky - chrom_tests_unit.gypi

8 years, 1 month ago (2012-11-13 01:51:51 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/11293241/1

8 years, 1 month ago (2012-11-13 22:13:22 UTC) #5

Change committed as 167541