Chromium Code Reviews
Help | Chromium Project | Sign in
(19)

Issue 11293140: MIPS: Add rotate-right instruction to hydrogen and use it instead of bitwise operations of the form… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 6 months ago by palfia
Modified:
2 years, 6 months ago
Reviewers:
kisg, Paul Lind, ulan, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Add rotate-right instruction to hydrogen and use it instead of bitwise operations of the form ((x >>> i) | (x << (32 - i))). Port r12855 (be965042) BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12971

Patch Set 1 #

Patch Set 2 : Rebased on r12963 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/mips/lithium-codegen-mips.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
palfia
2 years, 6 months ago (2012-11-07 01:50:08 UTC) #1
palfia
Rebased on r12963
2 years, 6 months ago (2012-11-14 23:46:30 UTC) #2
ulan
2 years, 6 months ago (2012-11-15 12:38:41 UTC) #3
LGTM, I will land it for you.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be