Issue 11293140: MIPS: Add rotate-right instruction to hydrogen and use it instead of bitwise operations of the form…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11293140: MIPS: Add rotate-right instruction to hydrogen and use it instead of bitwise operations of the form… (Closed)

Created:
8 years, 1 month ago by palfia

Modified:
8 years, 1 month ago

Reviewers:
kisg, Paul Lind, ulan, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Add rotate-right instruction to hydrogen and use it instead of bitwise operations of the form ((x >>> i) | (x << (32 - i))). Port r12855 (be965042) BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12971

Patch Set 1 #

Patch Set 2 : Rebased on r12963 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	src/mips/lithium-codegen-mips.cc	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download
	M	src/mips/lithium-mips.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM, I will land it for you.

Expand Messages | Collapse Messages