Issue 112913002: Split up HLoadNamedField and HStoreNamedField.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 112913002: Split up HLoadNamedField and HStoreNamedField.

Created:
7 years ago by Toon Verwaest

Modified:
7 years ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Split up HLoadNamedField and HStoreNamedField. Splits up HLoadNamedField into two loads for fields in the backing store. Splits up HStoreNamedField into 3 parts: - Load backing store if necessary - Store map if transitioning - Store field BUG=

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -112 lines)			Patch
M	src/hydrogen.cc	View	3 chunks	+18 lines, -15 lines	0 comments	Download
M	src/hydrogen-check-elimination.cc	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	src/hydrogen-escape-analysis.cc	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	8 chunks	+9 lines, -24 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	6 chunks	+26 lines, -5 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	5 chunks	+3 lines, -34 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	2 chunks	+5 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nice cleanup. Go ahead with the platform ports.

Expand Messages | Collapse Messages