Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 112833002: Fix NotifyStubFailureSaveDoubles generation for ia32. (Closed)

Created:
7 years ago by ulan
Modified:
7 years ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix NotifyStubFailureSaveDoubles generation for ia32. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18319

Patch Set 1 #

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/arguments.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ulan
PTAL
7 years ago (2013-12-11 14:05:37 UTC) #1
Jakob Kummerow
LGTM with comment: Please extend the comment in ClobberDoubleRegisters in arguments.cc to explicitly note "in ...
7 years ago (2013-12-11 14:08:18 UTC) #2
ulan
> Please extend the comment in ClobberDoubleRegisters in arguments.cc Done.
7 years ago (2013-12-11 14:16:25 UTC) #3
ulan
7 years ago (2013-12-17 09:10:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r18319.

Powered by Google App Engine
This is Rietveld 408576698