Issue 11282003: Trace when disabling optimized code (--trace-disabling-optimized-code)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11282003: Trace when disabling optimized code (--trace-disabling-optimized-code) (Closed)

Created:
8 years, 2 months ago by srdjan

Modified:
8 years, 2 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Trace when disabling optimized code (--trace-disabling-optimized-code) Committed: https://code.google.com/p/dart/source/detail?r=14036

Patch Set 2 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -6 lines)			Patch
	M	runtime/vm/compiler.cc	View		1 chunk	+1 line, -5 lines	0 comments	Download
	M	runtime/vm/object.cc	View	1	2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTMwC -ip https://chromiumcodereview.appspot.com/11282003/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://chromiumcodereview.appspot.com/11282003/diff/1/runtime/vm/object.cc#newcode3025 runtime/vm/object.cc:3025: Code::Handle(CurrentCode()).EntryPoint()); Pull this out to const Code& ...

8 years, 2 months ago (2012-10-24 20:27:00 UTC) #2

srdjan

8 years, 2 months ago (2012-10-24 20:29:32 UTC) #3

https://chromiumcodereview.appspot.com/11282003/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/11282003/diff/1/runtime/vm/object.cc#n...
runtime/vm/object.cc:3025: Code::Handle(CurrentCode()).EntryPoint());
On 2012/10/24 20:27:03, Ivan Posva wrote:
> Pull this out to
> const Code& current_code = Code::Handle(CurrentCode());

Done.

https://chromiumcodereview.appspot.com/11282003/diff/1/runtime/vm/object.cc#n...
runtime/vm/object.cc:3030: SetCode(Code::Handle(unoptimized_code()));
On 2012/10/24 20:27:03, Ivan Posva wrote:
> ditto

Done.

Expand Messages | Collapse Messages

Issue 11282003: Trace when disabling optimized code (--trace-disabling-optimized-code) (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages