Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 11280317: Send list of extensions with feedback reports. (Closed)

Created:
8 years ago by rkc
Modified:
8 years ago
Reviewers:
tbarzic
CC:
chromium-reviews
Visibility:
Public.

Description

Send list of extensions with feedback reports. If crash reporting is enabled, send the list of extensions installed on a ChromeOS machine with the feedback report. R=tbarzic@chromium.org BUG=158154 TEST=Verify that the list of extensions shows up in a feedback report, and only if crash reporting is enabled. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172273

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M chrome/browser/feedback/feedback_data.cc View 1 4 chunks +43 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rkc
8 years ago (2012-12-11 02:34:59 UTC) #1
tbarzic
On 2012/12/11 02:34:59, Rahul Chaturvedi wrote: lgtm
8 years ago (2012-12-11 02:40:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/11280317/1
8 years ago (2012-12-11 02:40:31 UTC) #3
tbarzic
https://codereview.chromium.org/11280317/diff/1/chrome/browser/feedback/feedback_data.cc File chrome/browser/feedback/feedback_data.cc (right): https://codereview.chromium.org/11280317/diff/1/chrome/browser/feedback/feedback_data.cc#newcode77 chrome/browser/feedback/feedback_data.cc:77: ExtensionService* service = default_profile->GetExtensionService(); Actually, this should be extensions::ExtensionSystem::Get(default_profile)->extension_service()
8 years ago (2012-12-11 02:47:57 UTC) #4
rkc
https://codereview.chromium.org/11280317/diff/1/chrome/browser/feedback/feedback_data.cc File chrome/browser/feedback/feedback_data.cc (right): https://codereview.chromium.org/11280317/diff/1/chrome/browser/feedback/feedback_data.cc#newcode77 chrome/browser/feedback/feedback_data.cc:77: ExtensionService* service = default_profile->GetExtensionService(); On 2012/12/11 02:47:57, tbarzic wrote: ...
8 years ago (2012-12-11 02:50:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/11280317/4
8 years ago (2012-12-11 02:50:49 UTC) #6
commit-bot: I haz the power
Change committed as 172273
8 years ago (2012-12-11 07:28:09 UTC) #7
Massag119
8 years ago (2012-12-11 15:40:03 UTC) #8
Message was sent while issue was closed.
On 2012/12/11 02:34:59, Rahul Chaturvedi wrote:

Massag119

Powered by Google App Engine
This is Rietveld 408576698