Chromium Code Reviews
Help | Chromium Project | Sign in
(44)

Issue 11280317: Send list of extensions with feedback reports. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 4 months ago by Rahul Chaturvedi
Modified:
1 year, 4 months ago
Reviewers:
tbarzic
CC:
chromium-reviews_chromium.org
Visibility:
Public.

Description

Send list of extensions with feedback reports.
If crash reporting is enabled, send the list of extensions installed on a ChromeOS machine with the feedback report.

R=tbarzic@chromium.org
BUG=158154
TEST=Verify that the list of extensions shows up in a feedback report, and only if crash reporting is enabled.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172273

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Lint Patch
M chrome/browser/feedback/feedback_data.cc View 1 4 chunks +43 lines, -0 lines 0 comments 1 errors Download
Commit:

Messages

Total messages: 8
Rahul Chaturvedi
1 year, 4 months ago #1
tbarzic
On 2012/12/11 02:34:59, Rahul Chaturvedi wrote: lgtm
1 year, 4 months ago #2
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/11280317/1
1 year, 4 months ago #3
tbarzic
https://codereview.chromium.org/11280317/diff/1/chrome/browser/feedback/feedback_data.cc File chrome/browser/feedback/feedback_data.cc (right): https://codereview.chromium.org/11280317/diff/1/chrome/browser/feedback/feedback_data.cc#newcode77 chrome/browser/feedback/feedback_data.cc:77: ExtensionService* service = default_profile->GetExtensionService(); Actually, this should be extensions::ExtensionSystem::Get(default_profile)->extension_service()
1 year, 4 months ago #4
Rahul Chaturvedi
https://codereview.chromium.org/11280317/diff/1/chrome/browser/feedback/feedback_data.cc File chrome/browser/feedback/feedback_data.cc (right): https://codereview.chromium.org/11280317/diff/1/chrome/browser/feedback/feedback_data.cc#newcode77 chrome/browser/feedback/feedback_data.cc:77: ExtensionService* service = default_profile->GetExtensionService(); On 2012/12/11 02:47:57, tbarzic wrote: ...
1 year, 4 months ago #5
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/11280317/4
1 year, 4 months ago #6
I haz the power (commit-bot)
Change committed as 172273
1 year, 4 months ago #7
Massag119
1 year, 4 months ago #8
Message was sent while issue was closed.
On 2012/12/11 02:34:59, Rahul Chaturvedi wrote:

Massag119
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6