Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 11280276: ARM: make MacroAssembler::LoadRoot emit exactly one instruction when in predictable code size scope. (Closed)

Created:
8 years ago by ulan
Modified:
8 years ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

ARM: make MacroAssembler::LoadRoot emit exactly one instruction when in predictable code size scope. BUG=v8:2439 R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=13113

Patch Set 1 #

Patch Set 2 : Fix long lines and sync comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -16 lines) Patch
M src/arm/codegen-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 1 chunk +12 lines, -8 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +12 lines, -7 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ulan
PTAL
8 years ago (2012-12-03 13:01:55 UTC) #1
danno
8 years ago (2012-12-03 13:05:43 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698