Create CachingRietveld to automatically cache results for presubmit checks.

Create CachingRietveld to automatically cache results for presubmit checks.

Multiple presubmit checks may call the same function multiple times, so it's
worth caching the results to speed up the presubmit check run.

Convert presubmit_support, git-cl and gcl to use it.

R=dpranke@chromium.org
BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169726

[Dirk Pranke, 2012-11-22 18:41:25]

lgtm, although it might be nice to have some tests that ensure that the caching
is actually caching.

[Isaac (away), 2012-11-26 05:12:39]

https://codereview.chromium.org/11280143/diff/1/rietveld.py
File rietveld.py (right):

https://codereview.chromium.org/11280143/diff/1/rietveld.py#newcode426
rietveld.py:426: def get_issue_properties(self, issue, messages):
get_issue_properties(<issue>, True) returns a superset of
get_issue_properties(<issue>, False).

Could we modify this for the False call to return the True call if it is cached?

[M-A Ruel, 2012-11-27 20:15:06]

ptal, now with proper unit test.

https://codereview.chromium.org/11280143/diff/1/rietveld.py
File rietveld.py (right):

https://codereview.chromium.org/11280143/diff/1/rietveld.py#newcode426
rietveld.py:426: def get_issue_properties(self, issue, messages):
On 2012/11/26 05:12:39, Isaac wrote:
> get_issue_properties(<issue>, True) returns a superset of
> get_issue_properties(<issue>, False).
> 
> Could we modify this for the False call to return the True call if it is
cached?

Done

[Dirk Pranke, 2012-11-27 20:27:41]

lgtm.

[commit-bot: I haz the power, 2012-11-27 20:31:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/11280143/5001

[Isaac (away), 2012-11-27 20:31:40]

lgtm

[commit-bot: I haz the power, 2012-11-27 20:33:53]

Change committed as 169726