git_cl.py - Issue 11280143: Create CachingRietveld to automatically cache results for presubmit checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 11280143: Create CachingRietveld to automatically cache results for presubmit checks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: add tests Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index f65d11ce5c5c79d89a0c6558113523cbe37005fd..092b0afff16b8bc8c5ba3629d945fd9f895ba416 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -742,8 +742,8 @@ or verify this branch is set up to track another (via the --track argument to

"""Returns an upload.RpcServer() to access this review's rietveld instance.

"""

if not self._rpc_server:

- self._rpc_server = rietveld.Rietveld(self.GetRietveldServer(),

- None, None)

+ self._rpc_server = rietveld.CachingRietveld(

+ self.GetRietveldServer(), None, None)

return self._rpc_server

def _IssueSetting(self):

« no previous file with comments | « gcl.py ('k') | presubmit_support.py » ('j') | no next file with comments »