chrome/installer/util/google_chrome_distribution.cc - Issue 11280067: Refactor SetOmahaExperimentLabel out of gcpai and into install_util.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/google_chrome_distribution.cc

Issue 11280067: Refactor SetOmahaExperimentLabel out of gcpai and into install_util. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: rebase; grt comments; unit tests Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/installer/gcapi/gcapi_omaha_experiment.cc ('K') | « chrome/installer/util/google_chrome_distribution.h ('k') | chrome/installer/util/google_chrome_distribution_dummy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/google_chrome_distribution.cc

diff --git a/chrome/installer/util/google_chrome_distribution.cc b/chrome/installer/util/google_chrome_distribution.cc

index 54a43db621333ff1258b3874f99a747008f6835f..2d7190c1098ad8360ccde3fe3f3b784e19cf7e2d 100644

--- a/chrome/installer/util/google_chrome_distribution.cc

+++ b/chrome/installer/util/google_chrome_distribution.cc

@@ -868,5 +868,8 @@ void GoogleChromeDistribution::InactiveUserToastExperiment(int flavor,

GetType()));

base::LaunchProcess(cmd, base::LaunchOptions(), NULL);

}

#endif

robertshield 2013/01/07 22:14:04 this preceded your change, but please could you ad

SteveT 2013/01/07 22:36:55 Done.

+bool GoogleChromeDistribution::ShouldSetExperimentLabels() {

+ return true;