Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Side by Side Diff: chrome/installer/util/google_chrome_distribution.cc

Issue 11280067: Refactor SetOmahaExperimentLabel out of gcpai and into install_util. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: rebase; grt comments; unit tests Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file defines specific implementation of BrowserDistribution class for 5 // This file defines specific implementation of BrowserDistribution class for
6 // Google Chrome. 6 // Google Chrome.
7 7
8 #include "chrome/installer/util/google_chrome_distribution.h" 8 #include "chrome/installer/util/google_chrome_distribution.h"
9 9
10 #include <vector> 10 #include <vector>
(...skipping 850 matching lines...) Expand 10 before | Expand all | Expand 10 after
861 // The user wants to uninstall. This is a best effort operation. Note that 861 // The user wants to uninstall. This is a best effort operation. Note that
862 // we waited for chrome to exit so the uninstall would not detect chrome 862 // we waited for chrome to exit so the uninstall would not detect chrome
863 // running. 863 // running.
864 bool system_level_toast = CommandLine::ForCurrentProcess()->HasSwitch( 864 bool system_level_toast = CommandLine::ForCurrentProcess()->HasSwitch(
865 installer::switches::kSystemLevelToast); 865 installer::switches::kSystemLevelToast);
866 866
867 CommandLine cmd(InstallUtil::GetChromeUninstallCmd(system_level_toast, 867 CommandLine cmd(InstallUtil::GetChromeUninstallCmd(system_level_toast,
868 GetType())); 868 GetType()));
869 base::LaunchProcess(cmd, base::LaunchOptions(), NULL); 869 base::LaunchProcess(cmd, base::LaunchOptions(), NULL);
870 } 870 }
871 #endif
robertshield 2013/01/07 22:14:04 this preceded your change, but please could you ad
SteveT 2013/01/07 22:36:55 Done.
871 872
872 #endif 873 bool GoogleChromeDistribution::ShouldSetExperimentLabels() {
874 return true;
875 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698