Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: cc/layer.cc

Issue 11276060: Pass accurate contentsScale to LayerImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layer.h ('k') | cc/layer_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layer.cc
diff --git a/cc/layer.cc b/cc/layer.cc
index 4c3912608c2448bb932ce16349d403e67dc7fc49..b36589d02dc2680803ae7cca1106f7ab83a3b932 100644
--- a/cc/layer.cc
+++ b/cc/layer.cc
@@ -64,7 +64,6 @@ Layer::Layer()
, m_renderTarget(0)
, m_drawTransformIsAnimating(false)
, m_screenSpaceTransformIsAnimating(false)
- , m_contentsScale(1.0)
, m_rasterScale(1.0)
, m_automaticallyComputeRasterScale(false)
, m_boundsContainPageScale(false)
@@ -120,13 +119,15 @@ void Layer::setNeedsCommit()
m_layerTreeHost->setNeedsCommit();
}
-IntRect Layer::layerRectToContentRect(const WebKit::WebRect& layerRect)
+IntRect Layer::layerRectToContentRect(const FloatRect& layerRect) const
{
- float widthScale = static_cast<float>(contentBounds().width()) / bounds().width();
- float heightScale = static_cast<float>(contentBounds().height()) / bounds().height();
- FloatRect contentRect(layerRect.x, layerRect.y, layerRect.width, layerRect.height);
- contentRect.scale(widthScale, heightScale);
- return enclosingIntRect(contentRect);
+ FloatRect contentRect(layerRect);
+ contentRect.scale(contentsScaleX(), contentsScaleY());
+ IntRect intContentRect = enclosingIntRect(contentRect);
+ // Intersect with content rect to avoid the extra pixel because for some
+ // values x and y, ceil((x / y) * y) may be x + 1.
+ intContentRect.intersect(IntRect(IntPoint(), contentBounds()));
+ return intContentRect;
}
void Layer::setParent(Layer* layer)
@@ -557,6 +558,7 @@ void Layer::pushPropertiesTo(LayerImpl* layer)
layer->setBackgroundColor(m_backgroundColor);
layer->setBounds(m_bounds);
layer->setContentBounds(contentBounds());
+ layer->setContentsScale(contentsScaleX(), contentsScaleY());
layer->setDebugBorderColor(m_debugBorderColor);
layer->setDebugBorderWidth(m_debugBorderWidth);
layer->setDebugName(m_debugName);
@@ -630,11 +632,6 @@ bool Layer::needMoreUpdates()
return false;
}
-bool Layer::needsContentsScale() const
-{
- return false;
-}
-
void Layer::setDebugBorderColor(SkColor color)
{
m_debugBorderColor = color;
@@ -653,13 +650,14 @@ void Layer::setDebugName(const std::string& debugName)
setNeedsCommit();
}
-void Layer::setContentsScale(float contentsScale)
+float Layer::contentsScaleX() const
{
- if (!needsContentsScale() || m_contentsScale == contentsScale)
- return;
- m_contentsScale = contentsScale;
+ return 1.0;
+}
- setNeedsDisplay();
+float Layer::contentsScaleY() const
+{
+ return 1.0;
}
void Layer::setRasterScale(float scale)
« no previous file with comments | « cc/layer.h ('k') | cc/layer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698