Chromium Code Reviews
Help | Chromium Project | Sign in
(62)

Issue 11275225: Add a callback to RemoteFileSyncService for reporting errors. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 8 months ago by tzik
Modified:
2 years, 8 months ago
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch
Visibility:
Public.

Description

Add a callback to RemoteFileSyncService for reporting errors for better error handling. BUG=156041 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166898

Patch Set 1 #

Patch Set 2 : build fix #

Total comments: 2

Patch Set 3 : +TODO comment #

Messages

Total messages: 6 (0 generated)
tzik
PTAL
2 years, 8 months ago (2012-11-09 07:38:45 UTC) #1
kinuko (slow until 10th)
lgtm except that: Please run try jobs and fill appropriate bug number (156041?).
2 years, 8 months ago (2012-11-09 07:44:39 UTC) #2
kinuko (slow until 10th)
http://codereview.chromium.org/11275225/diff/1001/chrome/browser/sync_file_system/sync_file_system_service.cc File chrome/browser/sync_file_system/sync_file_system_service.cc (right): http://codereview.chromium.org/11275225/diff/1001/chrome/browser/sync_file_system/sync_file_system_service.cc#newcode61 chrome/browser/sync_file_system/sync_file_system_service.cc:61: app_origin, fileapi::SyncStatusCallback()); Please add TODO to handle this callback ...
2 years, 8 months ago (2012-11-09 07:44:45 UTC) #3
tzik
Thanks! http://codereview.chromium.org/11275225/diff/1001/chrome/browser/sync_file_system/sync_file_system_service.cc File chrome/browser/sync_file_system/sync_file_system_service.cc (right): http://codereview.chromium.org/11275225/diff/1001/chrome/browser/sync_file_system/sync_file_system_service.cc#newcode61 chrome/browser/sync_file_system/sync_file_system_service.cc:61: app_origin, fileapi::SyncStatusCallback()); On 2012/11/09 07:44:45, kinuko wrote: > ...
2 years, 8 months ago (2012-11-09 07:52:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/11275225/6002
2 years, 8 months ago (2012-11-09 07:56:24 UTC) #5
commit-bot: I haz the power
2 years, 8 months ago (2012-11-09 11:54:49 UTC) #6
Change committed as 166898
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3ea459f