Move content\browser\web_contents to content namespace.

Move content\browser\web_contents to content namespace.

TBR=tfarina
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=164732

[tfarina, 2012-10-29 19:37:19]

lgtm

Sorry for the nits below.

Just ignore them ;)

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/n...
File content/browser/web_contents/navigation_controller_impl_unittest.cc
(right):

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/n...
content/browser/web_contents/navigation_controller_impl_unittest.cc:2969:
NOTIFICATION_NAV_ENTRY_COMMITTED));
will fit above.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/n...
content/browser/web_contents/navigation_controller_impl_unittest.cc:2986:
NOTIFICATION_NAV_ENTRY_COMMITTED));
will fit above.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/n...
content/browser/web_contents/navigation_controller_impl_unittest.cc:2992:
NOTIFICATION_NAV_ENTRY_COMMITTED));
will fit above.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/n...
File content/browser/web_contents/navigation_entry_impl.cc (right):

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/n...
content/browser/web_contents/navigation_entry_impl.cc:16: static int
GetUniqueIDInConstructor() {
namespace {

int ...

}  // namespace

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_contents_user_data_unittest.cc (right):

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_user_data_unittest.cc:67:
browser_context(), NULL));
fits above.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_contents_view_android.h (right):

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_view_android.h:56: const
ContextMenuParams& params,
will fit in the previous line.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_contents_view_mac.h (right):

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_view_mac.h:55: : public
WebContentsView,
can be moved above now.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_view_mac.h:90: const
ContextMenuParams& params,
fits above.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_contents_view_mac.mm (right):

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_view_mac.mm:78: WebContentsImpl*
web_contents,
will fit above now.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_view_mac.mm:282: const
ContextMenuParams& params,
can be moved above now.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_contents_view_win.h (right):

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_view_win.h:23: class
WebContentsViewDelegate;
sort

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_drag_dest_win.cc (right):

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_drag_dest_win.cc:92: OpenURLParams params(
OpenURLParams params(GURL(url), Referrer(), CURRENT_TAB,
                     PAGE_TRANSITION_AUTO_BOOKMARK, false);
                     ^ you can align like this now.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_drag_dest_win.cc:231: drop_effect :
DROPEFFECT_COPY;
this does fits above.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_drag_source_win.cc (right):

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_drag_source_win.cc:20: static void
GetCursorPositions(gfx::NativeWindow wnd, gfx::Point* client,
nit: no static, sorry for point out. :(

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_drag_source_win.cc:112: const
NotificationSource& source,
nit: indentation is off here!

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_drag_source_win.cc:114: if
(NOTIFICATION_WEB_CONTENTS_SWAPPED == type) {
note your fault of course, but I have seen more the opposite:
type == NOTIFICATION_

I think it's easier to read. :(

leave as is though ;)

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_drag_utils_win.cc (right):

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_drag_utils_win.cc:61: 
rm this extra blank line?

[jam, 2012-10-29 20:01:51]

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/n...
File content/browser/web_contents/navigation_controller_impl_unittest.cc
(right):

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/n...
content/browser/web_contents/navigation_controller_impl_unittest.cc:2969:
NOTIFICATION_NAV_ENTRY_COMMITTED));
On 2012/10/29 19:37:19, tfarina wrote:
> will fit above.

Done.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/n...
content/browser/web_contents/navigation_controller_impl_unittest.cc:2986:
NOTIFICATION_NAV_ENTRY_COMMITTED));
On 2012/10/29 19:37:19, tfarina wrote:
> will fit above.

Done.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/n...
content/browser/web_contents/navigation_controller_impl_unittest.cc:2992:
NOTIFICATION_NAV_ENTRY_COMMITTED));
On 2012/10/29 19:37:19, tfarina wrote:
> will fit above.

Done.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_contents_user_data_unittest.cc (right):

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_user_data_unittest.cc:67:
browser_context(), NULL));
On 2012/10/29 19:37:19, tfarina wrote:
> fits above.

Done.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_contents_view_android.h (right):

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_view_android.h:56: const
ContextMenuParams& params,
On 2012/10/29 19:37:19, tfarina wrote:
> will fit in the previous line.

Done.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_contents_view_mac.h (right):

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_view_mac.h:55: : public
WebContentsView,
On 2012/10/29 19:37:19, tfarina wrote:
> can be moved above now.

Done.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_view_mac.h:90: const
ContextMenuParams& params,
On 2012/10/29 19:37:19, tfarina wrote:
> fits above.

Done.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_contents_view_mac.mm (right):

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_view_mac.mm:78: WebContentsImpl*
web_contents,
On 2012/10/29 19:37:19, tfarina wrote:
> will fit above now.

Done.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_view_mac.mm:282: const
ContextMenuParams& params,
On 2012/10/29 19:37:19, tfarina wrote:
> can be moved above now.

Done.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_contents_view_win.h (right):

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_view_win.h:23: class
WebContentsViewDelegate;
On 2012/10/29 19:37:19, tfarina wrote:
> sort

Done.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_drag_dest_win.cc (right):

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_drag_dest_win.cc:92: OpenURLParams params(
On 2012/10/29 19:37:19, tfarina wrote:
> OpenURLParams params(GURL(url), Referrer(), CURRENT_TAB,
>                      PAGE_TRANSITION_AUTO_BOOKMARK, false);
>                      ^ you can align like this now.

Done.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_drag_dest_win.cc:231: drop_effect :
DROPEFFECT_COPY;
On 2012/10/29 19:37:19, tfarina wrote:
> this does fits above.

Done.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_drag_source_win.cc (right):

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_drag_source_win.cc:112: const
NotificationSource& source,
On 2012/10/29 19:37:19, tfarina wrote:
> nit: indentation is off here!

Done.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_drag_source_win.cc:114: if
(NOTIFICATION_WEB_CONTENTS_SWAPPED == type) {
On 2012/10/29 19:37:19, tfarina wrote:
> note your fault of course, but I have seen more the opposite:
> type == NOTIFICATION_
> 
> I think it's easier to read. :(
> 
> leave as is though ;)

Done.

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_drag_utils_win.cc (right):

http://codereview.chromium.org/11275062/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_drag_utils_win.cc:61: 
On 2012/10/29 19:37:19, tfarina wrote:
> rm this extra blank line?

Done.