Support for specifying an output directory (issue #106)

Support for specifying an output directory. This adds a directive-parser for
dart code which we use to extract imports and rewrite them. We also apply the
rewrite logic in CSS/js urls so that the html can be used form the output
location.

Committed: https://github.com/dart-lang/dart-web-components/commit/4468789

[Jennifer Messerly, 2012-10-25 04:26:25]

a few minor things, but lgtm otherwise

https://chromiumcodereview.appspot.com/11275029/diff/2001/lib/src/directive_p...
File lib/src/directive_parser.dart (right):

https://chromiumcodereview.appspot.com/11275029/diff/2001/lib/src/directive_p...
lib/src/directive_parser.dart:78: libraryName = parseQualifiedName();
fyi, this is not allowed by Dart language spec when I checked last week... it
only had an identifier and VM didn't like foo.bar :(

https://chromiumcodereview.appspot.com/11275029/diff/2001/lib/src/directive_p...
lib/src/directive_parser.dart:125: messages.error('expected an import url, but
found ${token}', null);
would be good to include the file name

https://chromiumcodereview.appspot.com/11275029/diff/2001/lib/src/directive_p...
lib/src/directive_parser.dart:128: var uri = token.value;
does the spec allow sequential string concat? i.e. to break up a long line

https://chromiumcodereview.appspot.com/11275029/diff/2001/lib/src/directive_p...
lib/src/directive_parser.dart:288: Token string() {
does spec allow raw or triple quoted strings? interpolation (gosh I hope not)?

I can't see any value in implementing those as they would be useless in imports,
but would be worth a note...

https://chromiumcodereview.appspot.com/11275029/diff/2001/lib/src/emitters.dart
File lib/src/emitters.dart (right):

https://chromiumcodereview.appspot.com/11275029/diff/2001/lib/src/emitters.da...
lib/src/emitters.dart:638: if (tag.attributes['rel'] == 'stylesheet' && href !=
null) {
I think this should be != "components". there are a bunch of link tags:

http://blog.whatwg.org/the-road-to-html-5-link-relations
http://dev.w3.org/html5/spec/links.html#linkTypes

[Siggi Cherem (dart-lang), 2012-10-25 05:17:28]

thanks John, submitting!

https://chromiumcodereview.appspot.com/11275029/diff/2001/lib/src/directive_p...
File lib/src/directive_parser.dart (right):

https://chromiumcodereview.appspot.com/11275029/diff/2001/lib/src/directive_p...
lib/src/directive_parser.dart:78: libraryName = parseQualifiedName();
On 2012/10/25 04:26:25, John Messerly wrote:
> fyi, this is not allowed by Dart language spec when I checked last week... it
> only had an identifier and VM didn't like foo.bar :(

Good question - it's not perfectly clear. The spec grammar says only identifier,
the vm crashes, but the text under the gramar (here
http://www.dartlang.org/docs/spec/latest/dart-language-specification.html#id....)

says:
A named library begins with the word library (possibly prefaced by any
applicable metadata annotations), followed by a **qualified identifier** that
gives the name of the library.

dart2js/dart_analyer accept it too, so I'll keep it in.

https://chromiumcodereview.appspot.com/11275029/diff/2001/lib/src/directive_p...
lib/src/directive_parser.dart:125: messages.error('expected an import url, but
found ${token}', null);
On 2012/10/25 04:26:25, John Messerly wrote:
> would be good to include the file name

Done.

https://chromiumcodereview.appspot.com/11275029/diff/2001/lib/src/directive_p...
lib/src/directive_parser.dart:128: var uri = token.value;
On 2012/10/25 04:26:25, John Messerly wrote:
> does the spec allow sequential string concat? i.e. to break up a long line

fixed. the spec allows it, but the vm crashes on it.

https://chromiumcodereview.appspot.com/11275029/diff/2001/lib/src/directive_p...
lib/src/directive_parser.dart:288: Token string() {
On 2012/10/25 04:26:25, John Messerly wrote:
> does spec allow raw or triple quoted strings? interpolation (gosh I hope not)?
> 
> I can't see any value in implementing those as they would be useless in
imports,
> but would be worth a note...
> 

ok added a note - seems that yes, multiline strings are allowed. Interpolation
not, the strings must be consts.

https://chromiumcodereview.appspot.com/11275029/diff/2001/lib/src/emitters.dart
File lib/src/emitters.dart (right):

https://chromiumcodereview.appspot.com/11275029/diff/2001/lib/src/emitters.da...
lib/src/emitters.dart:638: if (tag.attributes['rel'] == 'stylesheet' && href !=
null) {
On 2012/10/25 04:26:25, John Messerly wrote:
> I think this should be != "components". there are a bunch of link tags:
> 
> http://blog.whatwg.org/the-road-to-html-5-link-relations
> http://dev.w3.org/html5/spec/links.html#linkTypes

Done.