Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 11273096: [autofill] When hiding popups in the renderer also hide those in the browser. (Closed)

Created:
8 years, 1 month ago by Dan Beam
Modified:
8 years, 1 month ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, dhollowa+watch_chromium.org, Ilya Sherman, dyu1, darin-cc_chromium.org
Visibility:
Public.

Description

[autofill] When hiding popups in the renderer also hide those in the browser. BUG=157661 R=isherman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166147

Patch Set 1 #

Total comments: 2

Patch Set 2 : isherman@ review #

Total comments: 1

Patch Set 3 : fix #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M chrome/renderer/autofill/autofill_agent.h View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M chrome/renderer/autofill/autofill_agent.cc View 1 2 3 4 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dan Beam
8 years, 1 month ago (2012-10-29 23:05:07 UTC) #1
Ilya Sherman
LGTM, thanks :) https://chromiumcodereview.appspot.com/11273096/diff/1/chrome/renderer/autofill/autofill_agent.cc File chrome/renderer/autofill/autofill_agent.cc (right): https://chromiumcodereview.appspot.com/11273096/diff/1/chrome/renderer/autofill/autofill_agent.cc#newcode739 chrome/renderer/autofill/autofill_agent.cc:739: } nit: I think this should ...
8 years, 1 month ago (2012-10-29 23:14:19 UTC) #2
Dan Beam
https://chromiumcodereview.appspot.com/11273096/diff/1/chrome/renderer/autofill/autofill_agent.cc File chrome/renderer/autofill/autofill_agent.cc (right): https://chromiumcodereview.appspot.com/11273096/diff/1/chrome/renderer/autofill/autofill_agent.cc#newcode739 chrome/renderer/autofill/autofill_agent.cc:739: } On 2012/10/29 23:14:19, Ilya Sherman wrote: > nit: ...
8 years, 1 month ago (2012-10-30 00:44:15 UTC) #3
Ilya Sherman
LGTM
8 years, 1 month ago (2012-10-30 00:47:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/11273096/7001
8 years, 1 month ago (2012-11-06 01:51:13 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-06 04:40:11 UTC) #6
Change committed as 166147

Powered by Google App Engine
This is Rietveld 408576698