Chromium Code Reviews
Help | Chromium Project | Sign in
(1)

Issue 11273075: Treat leading zeros in JSON.parse correctly. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by Yang
Modified:
2 years, 4 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Treat leading zeros in JSON.parse correctly. R=verwaest@chromium.org BUG=158185 Committed: https://code.google.com/p/v8/source/detail?r=12830

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -39 lines) Patch
M src/json-parser.h View 1 chunk +41 lines, -30 lines 2 comments Download
A + test/mjsunit/regress/regress-crbug-158185.js View 1 chunk +10 lines, -9 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Yang
2 years, 4 months ago (2012-10-29 10:54:44 UTC) #1
Toon Verwaest
lgtm with comment. https://chromiumcodereview.appspot.com/11273075/diff/1/src/json-parser.h File src/json-parser.h (right): https://chromiumcodereview.appspot.com/11273075/diff/1/src/json-parser.h#newcode321 src/json-parser.h:321: if (position_ != start_position + 1 ...
2 years, 4 months ago (2012-10-29 11:08:22 UTC) #2
Yang
2 years, 4 months ago (2012-10-29 12:01:11 UTC) #3
https://chromiumcodereview.appspot.com/11273075/diff/1/src/json-parser.h
File src/json-parser.h (right):

https://chromiumcodereview.appspot.com/11273075/diff/1/src/json-parser.h#newc...
src/json-parser.h:321: if (position_ != start_position + 1 && c0_ == '"') {
On 2012/10/29 11:08:22, Toon Verwaest wrote:
> Now that this if moved into the parent if, the first part of the condition is
> always true. We just have to check that c0_ == '"'.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ecdb341-tainted