Issue 11273075: Treat leading zeros in JSON.parse correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11273075: Treat leading zeros in JSON.parse correctly. (Closed)

Created:
8 years, 1 month ago by Yang

Modified:
8 years, 1 month ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Treat leading zeros in JSON.parse correctly. R=verwaest@chromium.org BUG=158185 Committed: https://code.google.com/p/v8/source/detail?r=12830

Patch Set 1 #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -39 lines)			Patch
	M	src/json-parser.h	View		1 chunk	+41 lines, -30 lines	2 comments	Download
	A +	test/mjsunit/regress/regress-crbug-158185.js	View		1 chunk	+10 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

lgtm with comment. https://chromiumcodereview.appspot.com/11273075/diff/1/src/json-parser.h File src/json-parser.h (right): https://chromiumcodereview.appspot.com/11273075/diff/1/src/json-parser.h#newcode321 src/json-parser.h:321: if (position_ != start_position + 1 ...

8 years, 1 month ago (2012-10-29 11:08:22 UTC) #2

Yang

8 years, 1 month ago (2012-10-29 12:01:11 UTC) #3

https://chromiumcodereview.appspot.com/11273075/diff/1/src/json-parser.h
File src/json-parser.h (right):

https://chromiumcodereview.appspot.com/11273075/diff/1/src/json-parser.h#newc...
src/json-parser.h:321: if (position_ != start_position + 1 && c0_ == '"') {
On 2012/10/29 11:08:22, Toon Verwaest wrote:
> Now that this if moved into the parent if, the first part of the condition is
> always true. We just have to check that c0_ == '"'.

Done.

Expand Messages | Collapse Messages