Chromium Code Reviews
Help | Chromium Project | Sign in
(55)

Issue 11272043: [Autofill] Enable client-side pruning of old autocomplete data. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Ilya Sherman
Modified:
1 year, 5 months ago
CC:
chromium-reviews_chromium.org
Visibility:
Public.

Description

[Autofill] Enable client-side pruning of old autocomplete data.

BUG=28990
TBR=thakis@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165888

Patch Set 1 #

Patch Set 2 : Crank probability up to 100% #

Patch Set 3 : Set different probabilities depending on channel #

Total comments: 2

Patch Set 4 : Nada #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Lint Patch
M chrome/browser/webdata/autocomplete_syncable_service.cc View 1 2 3 2 chunks +10 lines, -2 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 20
Ilya Sherman
1 year, 5 months ago #1
timsteele
LGTM, sorry I didn't get to this yesterday. We should make sure this hits a ...
1 year, 5 months ago #2
Ilya Sherman
On 2012/10/26 21:34:05, timsteele wrote: > LGTM, sorry I didn't get to this yesterday. We ...
1 year, 5 months ago #3
Ilya Sherman
Ping. Should I commit this as is, or do we want to lower the percentage?
1 year, 5 months ago #4
Ilya Sherman
Tim, I've updated the code to set different probabilities depending on what channel it's running ...
1 year, 5 months ago #5
timsteele
lgtm https://chromiumcodereview.appspot.com/11272043/diff/6001/chrome/browser/webdata/autocomplete_syncable_service.cc File chrome/browser/webdata/autocomplete_syncable_service.cc (right): https://chromiumcodereview.appspot.com/11272043/diff/6001/chrome/browser/webdata/autocomplete_syncable_service.cc#newcode88 chrome/browser/webdata/autocomplete_syncable_service.cc:88: double culling_probability; It's best to initialize (to 0, ...
1 year, 5 months ago #6
Ilya Sherman
https://chromiumcodereview.appspot.com/11272043/diff/6001/chrome/browser/webdata/autocomplete_syncable_service.cc File chrome/browser/webdata/autocomplete_syncable_service.cc (right): https://chromiumcodereview.appspot.com/11272043/diff/6001/chrome/browser/webdata/autocomplete_syncable_service.cc#newcode88 chrome/browser/webdata/autocomplete_syncable_service.cc:88: double culling_probability; On 2012/11/02 17:46:11, timsteele wrote: > It's ...
1 year, 5 months ago #7
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/11272043/6002
1 year, 5 months ago #8
I haz the power (commit-bot)
Presubmit check for 11272043-6002 failed and returned exit status 1. Running presubmit commit checks ...
1 year, 5 months ago #9
Ilya Sherman
TBR Nico for OWNERS (I'm adding an OWNERS file for webdata/ in [ https://chromiumcodereview.appspot.com/11367055/ ]).
1 year, 5 months ago #10
Ilya Sherman
(re-send mail after adding Nico to reviewers line)
1 year, 5 months ago #11
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/11272043/6002
1 year, 5 months ago #12
Nico (ooo Apr 18 - Apr 20)
lgtm stamp
1 year, 5 months ago #13
I haz the power (commit-bot)
Retried try job too often for step(s) content_browsertests
1 year, 5 months ago #14
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/11272043/6002
1 year, 5 months ago #15
I haz the power (commit-bot)
Retried try job too often for step(s) content_browsertests
1 year, 5 months ago #16
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/11272043/6002
1 year, 5 months ago #17
I haz the power (commit-bot)
Retried try job too often for step(s) content_browsertests
1 year, 5 months ago #18
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/11272043/6002
1 year, 5 months ago #19
I haz the power (commit-bot)
1 year, 5 months ago #20
Change committed as 165888
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6