[Autofill] Enable client-side pruning of old autocomplete data.

[Autofill] Enable client-side pruning of old autocomplete data.

BUG=28990
TBR=thakis@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165888

[tim (not reviewing), 2012-10-26 21:34:05]

LGTM, sorry I didn't get to this yesterday. We should make sure this hits a
canary before dev.

[Ilya Sherman, 2012-10-26 21:48:32]

On 2012/10/26 21:34:05, timsteele wrote:
> LGTM, sorry I didn't get to this yesterday. We should make sure this hits a
> canary before dev.

Hmm, I'm not sure that we can guarantee that.  Perhaps we should lower the
percentage rather than trying to outguess the Chrome release schedule?

[Ilya Sherman, 2012-11-01 07:03:01]

Ping.  Should I commit this as is, or do we want to lower the percentage?

[Ilya Sherman, 2012-11-02 01:18:57]

Tim, I've updated the code to set different probabilities depending on what
channel it's running as.  PTAL, with apologies for asking you to review this
same CL twice.

[tim (not reviewing), 2012-11-02 17:46:11]

lgtm

https://chromiumcodereview.appspot.com/11272043/diff/6001/chrome/browser/webd...
File chrome/browser/webdata/autocomplete_syncable_service.cc (right):

https://chromiumcodereview.appspot.com/11272043/diff/6001/chrome/browser/webd...
chrome/browser/webdata/autocomplete_syncable_service.cc:88: double
culling_probability;
It's best to initialize (to 0, I suppose).

[Ilya Sherman, 2012-11-02 23:12:34]

https://chromiumcodereview.appspot.com/11272043/diff/6001/chrome/browser/webd...
File chrome/browser/webdata/autocomplete_syncable_service.cc (right):

https://chromiumcodereview.appspot.com/11272043/diff/6001/chrome/browser/webd...
chrome/browser/webdata/autocomplete_syncable_service.cc:88: double
culling_probability;
On 2012/11/02 17:46:11, timsteele wrote:
> It's best to initialize (to 0, I suppose).

Done.

[commit-bot: I haz the power, 2012-11-02 23:12:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/11272043/6002

[commit-bot: I haz the power, 2012-11-02 23:12:51]

Presubmit check for 11272043-6002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[Ilya Sherman, 2012-11-02 23:13:50]

TBR Nico for OWNERS (I'm adding an OWNERS file for webdata/ in [
https://chromiumcodereview.appspot.com/11367055/ ]).

[Ilya Sherman, 2012-11-02 23:14:19]

(re-send mail after adding Nico to reviewers line)

[commit-bot: I haz the power, 2012-11-02 23:15:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/11272043/6002

[Nico, 2012-11-02 23:15:52]

lgtm stamp

[commit-bot: I haz the power, 2012-11-03 02:59:02]

Retried try job too often for step(s) content_browsertests

[commit-bot: I haz the power, 2012-11-03 03:16:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/11272043/6002

[commit-bot: I haz the power, 2012-11-03 06:04:35]

Retried try job too often for step(s) content_browsertests

[commit-bot: I haz the power, 2012-11-03 09:08:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/11272043/6002

[commit-bot: I haz the power, 2012-11-03 11:52:44]

Retried try job too often for step(s) content_browsertests

[commit-bot: I haz the power, 2012-11-04 10:03:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/11272043/6002

[commit-bot: I haz the power, 2012-11-05 01:51:30]

Change committed as 165888