DevTools: “Dock to right” broken after turning a tab into a window of its own.

chrome/browser/debugger/devtools_window.h

Index: chrome/browser/debugger/devtools_window.h
diff --git a/chrome/browser/debugger/devtools_window.h b/chrome/browser/debugger/devtools_window.h
index 84dc217201d1920448872d67372acc452c016c39..ef216c8ec92fd21938503577c3cb419065c4d09b 100644
--- a/chrome/browser/debugger/devtools_window.h
+++ b/chrome/browser/debugger/devtools_window.h
@@ -87,9 +87,11 @@ class DevToolsWindow : private content::NotificationObserver,
   TabContents* tab_contents() { return tab_contents_; }
   Browser* browser() { return browser_; }  // For tests.
   DevToolsDockSide dock_side() { return dock_side_; }
-  content::DevToolsClientHost* devtools_client_host() {
-    return frontend_host_;
-  }
+  content::DevToolsClientHost* devtools_client_host() { return frontend_host_; }
+  int GetWidth(int container_width);

[Peter Kasting, 2012/10/24 21:18:09]

These getters should be const.

You need to document each of these, especially since you have implemented
special behaviors like passing in -1.

[pfeldman, 2012/10/25 15:17:40]

This getter will lazily fetch the value from the preferences, so it is not const
strictly speaking. Also, it will never return negative values.

+  int GetHeight(int container_height);
+  void SetWidth(int width);
+  void SetHeight(int height);
 
  private:
   static DevToolsWindow* Create(Profile* profile,
@@ -183,6 +185,8 @@ class DevToolsWindow : private content::NotificationObserver,
   content::NotificationRegistrar registrar_;
   content::DevToolsClientHost* frontend_host_;
   scoped_ptr<DevToolsFileHelper> file_helper_;
+  int width_;
+  int height_;
   DISALLOW_COPY_AND_ASSIGN(DevToolsWindow);
 };