DevTools: “Dock to right” broken after turning a tab into a window of its own.

chrome/browser/debugger/devtools_window.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_
 #define CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 69 matching lines @@
   // Overridden from DevToolsClientHost.
   virtual void InspectedContentsClosing() OVERRIDE;
   virtual void ContentsReplaced(content::WebContents* new_contents) OVERRIDE;
   content::RenderViewHost* GetRenderViewHost();
 
   void Show(DevToolsToggleAction action);
 
   TabContents* tab_contents() { return tab_contents_; }
   Browser* browser() { return browser_; }  // For tests.
   DevToolsDockSide dock_side() { return dock_side_; }
-  content::DevToolsClientHost* devtools_client_host() {
-    return frontend_host_;
-  }
+  content::DevToolsClientHost* devtools_client_host() { return frontend_host_; }
+  int GetWidth(int container_width);

[Peter Kasting, 2012/10/24 21:18:09]

These getters should be const.

You need to document each of these, especially since you have implemented
special behaviors like passing in -1.

[pfeldman, 2012/10/25 15:17:40]

This getter will lazily fetch the value from the preferences, so it is not const
strictly speaking. Also, it will never return negative values.

+  int GetHeight(int container_height);
+  void SetWidth(int width);
+  void SetHeight(int height);
 
  private:
   static DevToolsWindow* Create(Profile* profile,
                                 content::RenderViewHost* inspected_rvh,
                                 DevToolsDockSide dock_side,
                                 bool shared_worker_frontend);
   DevToolsWindow(TabContents* tab_contents,
                  Profile* profile,
                  content::RenderViewHost* inspected_rvh,
                  DevToolsDockSide dock_side);
@@ skipping 73 matching lines @@
   Profile* profile_;
   TabContents* inspected_tab_;
   TabContents* tab_contents_;
   Browser* browser_;
   DevToolsDockSide dock_side_;
   bool is_loaded_;
   DevToolsToggleAction action_on_load_;
   content::NotificationRegistrar registrar_;
   content::DevToolsClientHost* frontend_host_;
   scoped_ptr<DevToolsFileHelper> file_helper_;
+  int width_;
+  int height_;
   DISALLOW_COPY_AND_ASSIGN(DevToolsWindow);
 };
 
 #endif  // CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_