Chromium Code Reviews
Help | Chromium Project | Sign in
(195)

Issue 11271021: Correctly check for stack limit in JSON.stringify. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by Yang
Modified:
2 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Correctly check for stack limit in JSON.stringify. Changes include: - inline functions in a way as not to waste stack space. - reset StackReserveSize to the value prior to r12808. - check stack overflow dynamically. R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=12814

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -25 lines) Patch
M build/common.gypi View 2 chunks +1 line, -6 lines 0 comments Download
M src/json-stringifier.h View 6 chunks +14 lines, -15 lines 0 comments Download
M test/mjsunit/json-recursive.js View 1 chunk +6 lines, -4 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
Yang
2 years, 9 months ago (2012-10-25 12:01:59 UTC) #1
ulan
2 years, 9 months ago (2012-10-25 12:08:36 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 5fa3ca5