Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 11271018: Update policy presubmit chat after two policies were renamed (Closed)

Created:
8 years, 1 month ago by bartfab (slow)
Modified:
8 years, 1 month ago
Reviewers:
Joao da Silva
CC:
chromium-reviews
Visibility:
Public.

Description

Update policy presubmit check after two policies were renamed The policies related to Drive were renamed from GData* to Drive*. This CL updates the policy presubmit check accordingly. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=164041

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nit addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/policy/syntax_check_policy_template_json.py View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bartfab (slow)
Hi Joao, could you please have a look?
8 years, 1 month ago (2012-10-25 08:06:39 UTC) #1
Joao da Silva
lgtm https://codereview.chromium.org/11271018/diff/1/chrome/app/policy/syntax_check_policy_template_json.py File chrome/app/policy/syntax_check_policy_template_json.py (right): https://codereview.chromium.org/11271018/diff/1/chrome/app/policy/syntax_check_policy_template_json.py#newcode48 chrome/app/policy/syntax_check_policy_template_json.py:48: 'DriveDisabledOverCellular', nit: alphabetical order
8 years, 1 month ago (2012-10-25 08:13:04 UTC) #2
bartfab (slow)
https://chromiumcodereview.appspot.com/11271018/diff/1/chrome/app/policy/syntax_check_policy_template_json.py File chrome/app/policy/syntax_check_policy_template_json.py (right): https://chromiumcodereview.appspot.com/11271018/diff/1/chrome/app/policy/syntax_check_policy_template_json.py#newcode48 chrome/app/policy/syntax_check_policy_template_json.py:48: 'DriveDisabledOverCellular', On 2012/10/25 08:13:04, Joao da Silva wrote: > ...
8 years, 1 month ago (2012-10-25 08:14:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/11271018/5001
8 years, 1 month ago (2012-10-25 08:14:58 UTC) #4
commit-bot: I haz the power
8 years, 1 month ago (2012-10-25 09:15:55 UTC) #5
Retried try job too often for step(s) unit_tests

Powered by Google App Engine
This is Rietveld 408576698