[autofill] Adding new API to request an interactive autocomplete UI flow.

chrome/renderer/autofill/autofill_agent.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/autofill/autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "base/string_util.h"
 #include "base/string_split.h"
@@ skipping 141 matching lines @@
     IPC_MESSAGE_HANDLER(AutofillMsg_SetAutofillActionPreview,
                         OnSetAutofillActionPreview)
     IPC_MESSAGE_HANDLER(AutofillMsg_ClearPreviewedForm,
                         OnClearPreviewedForm)
     IPC_MESSAGE_HANDLER(AutofillMsg_SetNodeText,
                         OnSetNodeText)
     IPC_MESSAGE_HANDLER(AutofillMsg_AcceptDataListSuggestion,
                         OnAcceptDataListSuggestion)
     IPC_MESSAGE_HANDLER(AutofillMsg_AcceptPasswordAutofillSuggestion,
                         OnAcceptPasswordAutofillSuggestion)
+    IPC_MESSAGE_HANDLER(AutofillMsg_RequestAutocompleteFinished,
+                        OnRequestAutocompleteFinished)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 void AutofillAgent::DidFinishDocumentLoad(WebFrame* frame) {
   // The document has now been fully loaded.  Scan for forms to be sent up to
   // the browser.
   std::vector<FormData> forms;
   form_cache_.ExtractForms(*frame, &forms);
@@ skipping 34 matching lines @@
   Send(new AutofillHostMsg_HideAutofillPopup(routing_id()));
 }
 
 void AutofillAgent::DidChangeScrollOffset(WebKit::WebFrame*) {
   // Any time the scroll offset changes, the page's content moves, so Autofill
   // popups should be hidden. This is only needed for the new Autofill UI
   // because WebKit already knows to hide the old UI when this occurs.
   Send(new AutofillHostMsg_HideAutofillPopup(routing_id()));
 }
 
+void AutofillAgent::RequestAutocomplete(WebKit::WebFrame* frame,
+                                        const WebFormElement& form) {
+
+  // TODO(dbeam): should popups be hidden here? Maybe after a view message from
+  // the browser to say whether the interactive autocomplete UI will show?

[Ilya Sherman, 2012/10/26 03:30:52]

Yes, we should hide popups and cancel any pending requests (by incrementing the
autofill_query_id_ so that any incoming responses are discarded as stale).  In
fact, we could probably just rename autofill_query_id_ to something more like
ipc_message_id_, and reuse it here.

[Dan Beam, 2012/10/26 05:51:44]

creating separate counter for this request like we talked about

+
+  FormData form_data;
+  if (WebFormElementToFormData(form,
+                               WebFormControlElement(),
+                               REQUIRE_AUTOCOMPLETE,
+                               static_cast<ExtractMask>(
+                                   EXTRACT_VALUE | EXTRACT_OPTION_TEXT),

[Ilya Sherman, 2012/10/26 03:30:52]

nit: I don't think we need to extract values or option text.  These are useful
for heuristics, but probably aren't needed for the interactive dialog UI.

[Dan Beam, 2012/10/26 05:51:44]

Done.

+                               &form_data,
+                               NULL)) {
+    form_ = form;
+    Send(new AutofillHostMsg_RequestAutocomplete(routing_id(), form_data));
+  }
+}
+
 bool AutofillAgent::InputElementClicked(const WebInputElement& element,
                                         bool was_focused,
                                         bool is_focused) {
   if (was_focused)
     ShowSuggestions(element, true, false, true);
 
   return false;
 }
 
 bool AutofillAgent::InputElementLostFocus() {
@@ skipping 349 matching lines @@
 void AutofillAgent::OnAcceptPasswordAutofillSuggestion(const string16& value) {
   // We need to make sure this is handled here because the browser process
   // skipped it handling because it believed it would be handled here. If it
   // isn't handled here then the browser logic needs to be updated.
   bool handled = password_autofill_manager_->DidAcceptAutofillSuggestion(
       element_,
       value);
   DCHECK(handled);
 }
 
+void AutofillAgent::OnRequestAutocompleteFinished(bool success) {
+  form_.dispatchAutocompleteEvent(success);

[Ilya Sherman, 2012/10/26 03:30:52]

We should do some sort of checking here to make sure the form still exists.  It
would be bad if the form could be removed from the DOM while we were processing
the request, and if that caused us to crash.

[Dan Beam, 2012/10/26 05:51:44]

why would it being removed from the DOM cause us to crash?  alternatively, do
you know how I'd check if this is in the DOM still (didn't see any examples in
this class)?

+}
+
 void AutofillAgent::ShowSuggestions(const WebInputElement& element,
                                     bool autofill_on_empty_values,
                                     bool requires_caret_at_end,
                                     bool display_warning_if_disabled) {
   if (!element.isEnabled() || element.isReadOnly() || !element.isTextField() ||
       element.isPasswordField() || !element.suggestedValue().isEmpty())
     return;
 
   // Don't attempt to autofill with values that are too large or if filling
   // criteria are not met.
@@ skipping 101 matching lines @@
 void AutofillAgent::SetNodeText(const string16& value,
                                 WebKit::WebInputElement* node) {
   did_set_node_text_ = true;
   string16 substring = value;
   substring = substring.substr(0, node->maxLength());
 
   node->setEditingValue(substring);
 }
 
 }  // namespace autofill