[autofill] Adding new API to request an interactive autocomplete UI flow.

chrome/common/autofill_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message file, hence no include guard.
 
 #include <string>
 
 #include "base/time.h"
 #include "chrome/common/common_param_traits_macros.h"
@@ skipping 117 matching lines @@
 
 // Tells the renderer that the password field has accept the suggestion.
 IPC_MESSAGE_ROUTED1(AutofillMsg_AcceptPasswordAutofillSuggestion,
                     string16 /* username value*/)
 
 // Tells the renderer that this password form is not blacklisted.  A form can
 // be blacklisted if a user chooses "never save passwords for this site".
 IPC_MESSAGE_ROUTED1(AutofillMsg_FormNotBlacklisted,
                     content::PasswordForm /* form checked */)
 
+// Sent when interactive autocomplete is cancelled or finished successfully.
+IPC_MESSAGE_ROUTED1(AutofillMsg_RequestAutocompleteFinished,
+                    bool /* whether the user pressed cancel */)

[Evan Stade, 2012/10/26 03:23:02]

"whether the user pressed cancel" is very specific. What if the user presses
escape or presses the [x]? What if we run into some other kind of error that
prevents handling the request? For example, the request could originate from an
instant-loaded page, in which case we'd want to ignore it instead of showing a
UI. Therefore the bool should be described as "success/failure". Also I think
true should correlate to success.

[Ilya Sherman, 2012/10/26 03:30:52]

nit: Boolean parameters are hard to make sense of at the call site.  We
generally prefer enumerated values with descriptive names.

[Dan Beam, 2012/10/26 05:51:44]

I see 3 examples of bools in messages in this file that could be enums.  Is this
different?  Should we update the others?

+
 // Autofill messages sent from the renderer to the browser.
 
 // Notification that forms have been seen that are candidates for
 // filling/submitting by the AutofillManager.
 IPC_MESSAGE_ROUTED2(AutofillHostMsg_FormsSeen,
                     std::vector<FormData> /* forms */,
                     base::TimeTicks /* timestamp */)
 
 // Notification that password forms have been seen that are candidates for
 // filling/submitting by the password manager.
@@ skipping 36 matching lines @@
                     FormFieldData /* the form field  */,
                     int /* profile unique ID */)
 
 // Sent when a form is previewed with Autofill suggestions.
 IPC_MESSAGE_ROUTED0(AutofillHostMsg_DidPreviewAutofillFormData)
 
 // Sent when a form is filled with Autofill suggestions.
 IPC_MESSAGE_ROUTED1(AutofillHostMsg_DidFillAutofillFormData,
                     base::TimeTicks /* timestamp */)
 
+// Sent when a form receives a request to do interactive autocomplete.
+IPC_MESSAGE_ROUTED1(AutofillHostMsg_RequestAutocomplete,
+                    FormData /* the form */)
+
 // Instructs the browser to remove the specified Autocomplete entry from the
 // database.
 IPC_MESSAGE_ROUTED2(AutofillHostMsg_RemoveAutocompleteEntry,
                     string16 /* field name */,
                     string16 /* value */)
 
 // Instructs the browser to show the Autofill dialog.
 IPC_MESSAGE_ROUTED0(AutofillHostMsg_ShowAutofillDialog)
 
 // Send when a text field is done editing.
@@ skipping 21 matching lines @@
                     FormFieldData /* the form field */,
                     gfx::Rect /* input field bounds, window-relative */,
                     std::vector<string16> /* suggestions */)
 
 // Inform browser of data list values for the curent field.
 IPC_MESSAGE_ROUTED4(AutofillHostMsg_SetDataList,
                     std::vector<string16> /* values */,
                     std::vector<string16> /* labels */,
                     std::vector<string16> /* icons */,
                     std::vector<int> /* unique ids */)