Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 11269035: Fix memory leak in DeoptimizerData. (Closed)

Created:
8 years, 2 months ago by ulan
Modified:
8 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/deoptimizer.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ulan
PTAL
8 years, 2 months ago (2012-10-25 08:08:57 UTC) #1
Sven Panne
https://chromiumcodereview.appspot.com/11269035/diff/1/src/deoptimizer.cc File src/deoptimizer.cc (right): https://chromiumcodereview.appspot.com/11269035/diff/1/src/deoptimizer.cc#newcode66 src/deoptimizer.cc:66: DeoptimizingCodeListNode* prev = NULL; DBC: Move the declaration into ...
8 years, 2 months ago (2012-10-25 08:22:26 UTC) #2
ulan
https://chromiumcodereview.appspot.com/11269035/diff/1/src/deoptimizer.cc File src/deoptimizer.cc (right): https://chromiumcodereview.appspot.com/11269035/diff/1/src/deoptimizer.cc#newcode66 src/deoptimizer.cc:66: DeoptimizingCodeListNode* prev = NULL; On 2012/10/25 08:22:26, Sven Panne ...
8 years, 2 months ago (2012-10-25 08:26:02 UTC) #3
Michael Starzinger
8 years, 2 months ago (2012-10-25 08:43:25 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698