Fix memory leak in DeoptimizerData.

src/deoptimizer.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 44 matching lines @@
   if (eager_deoptimization_entry_code_ != NULL) {
     Isolate::Current()->memory_allocator()->Free(
         eager_deoptimization_entry_code_);
     eager_deoptimization_entry_code_ = NULL;
   }
   if (lazy_deoptimization_entry_code_ != NULL) {
     Isolate::Current()->memory_allocator()->Free(
         lazy_deoptimization_entry_code_);
     lazy_deoptimization_entry_code_ = NULL;
   }
+  if (deoptimizing_code_list_ != NULL) {
+    DeoptimizingCodeListNode* prev = NULL;

[Sven Panne, 2012/10/25 08:22:26]

DBC: Move the declaration into the loop where it is needed. Small scopes are
good scopes... :-)

[ulan, 2012/10/25 08:26:02]

Done. I also removed the outer null check.

+    DeoptimizingCodeListNode* current = deoptimizing_code_list_;
+    while (current != NULL) {
+      prev = current;
+      current = current->next();
+      delete prev;
+    }
+    deoptimizing_code_list_ = NULL;
+  }
 }
 
 
 #ifdef ENABLE_DEBUGGER_SUPPORT
 void DeoptimizerData::Iterate(ObjectVisitor* v) {
   if (deoptimized_frame_info_ != NULL) {
     deoptimized_frame_info_->Iterate(v);
   }
 }
 #endif
@@ skipping 1914 matching lines @@
 
 void DeoptimizedFrameInfo::Iterate(ObjectVisitor* v) {
   v->VisitPointer(BitCast<Object**>(&function_));
   v->VisitPointers(parameters_, parameters_ + parameters_count_);
   v->VisitPointers(expression_stack_, expression_stack_ + expression_count_);
 }
 
 #endif  // ENABLE_DEBUGGER_SUPPORT
 
 } }  // namespace v8::internal