[dart2dart] fix after https://codereview.chromium.org/11227007

[dart2dart] fix after https://codereview.chromium.org/11227007

Committed: https://code.google.com/p/dart/source/detail?r=14216

[ahe, 2012-10-26 14:13:49]

I don't think this looks too bad. But that is because all that bad stuff you
have to do to print a constructor element will soon be much simpler, as in:

printConstructorOn(FunctionElement constructor, StringBuffer sb) {
  constructor.getEnclosingClass().name.printOn(sb);
  SourceString name = constructor.name;
  if (name != const SourceString('')) {
    sb.add('.');
    name.printOn(sb);
  }
}

https://chromiumcodereview.appspot.com/11267046/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/11267046/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:306:
compiler.resolverWorld.instantiatedClasses.forEach((ClassElement classElement) {
Long line.

https://chromiumcodereview.appspot.com/11267046/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/renamer.dart (right):

https://chromiumcodereview.appspot.com/11267046/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/renamer.dart:90: for (Link<DartType>
link = argumentsLink.tail; !link.isEmpty(); link = link.tail) {
long line.

https://chromiumcodereview.appspot.com/11267046/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/renamer.dart:99: String
renameConstructor(Element element, DartType type, Function renameString,
Function renameElement) {
Long line.

https://chromiumcodereview.appspot.com/11267046/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/renamer.dart:103: String name =
element.name.slowToString();
This should really just be something like:

element.name.printOn(result);

But it cannot be just yet, because of other broken stuff in the front end.

https://chromiumcodereview.appspot.com/11267046/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/renamer.dart:104: if
(element.name.slowToString() != element.getEnclosingClass().name.slowToString())
{
Long line.

https://chromiumcodereview.appspot.com/11267046/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/renamer.dart:104: if
(element.name.slowToString() != element.getEnclosingClass().name.slowToString())
{
Why are you calling slowToString on these names? You can just compare them
directly.

https://chromiumcodereview.appspot.com/11267046/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/renamer.dart:105: // Named constructor
or factory. Is there a more reliable way to check this case?
Long line.

https://chromiumcodereview.appspot.com/11267046/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/renamer.dart:106: // Could also be
factory for another interface.
We plan to use the empty string as name of constructors. Also, be careful that
you're not spending energy on handling factories with odd names that will be
removed soon.

https://chromiumcodereview.appspot.com/11267046/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/renamer.dart:113: result.add(name);
This will get cleaned up. It is a ripe mess that we create these names right
now.

[Roman, 2012-10-29 18:14:12]

Anton, PTAL.

Don't look at test status, I'll update them shortly.

https://chromiumcodereview.appspot.com/11267046/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/11267046/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:306:
compiler.resolverWorld.instantiatedClasses.forEach((ClassElement classElement) {
On 2012/10/26 14:13:49, ahe wrote:
> Long line.

Done.

https://chromiumcodereview.appspot.com/11267046/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/renamer.dart (right):

https://chromiumcodereview.appspot.com/11267046/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/renamer.dart:90: for (Link<DartType>
link = argumentsLink.tail; !link.isEmpty(); link = link.tail) {
On 2012/10/26 14:13:49, ahe wrote:
> long line.

Done.

https://chromiumcodereview.appspot.com/11267046/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/renamer.dart:99: String
renameConstructor(Element element, DartType type, Function renameString,
Function renameElement) {
On 2012/10/26 14:13:49, ahe wrote:
> Long line.

Done.

https://chromiumcodereview.appspot.com/11267046/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/renamer.dart:104: if
(element.name.slowToString() != element.getEnclosingClass().name.slowToString())
{
On 2012/10/26 14:13:49, ahe wrote:
> Why are you calling slowToString on these names? You can just compare them
> directly.

Done.

https://chromiumcodereview.appspot.com/11267046/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/renamer.dart:105: // Named constructor
or factory. Is there a more reliable way to check this case?
On 2012/10/26 14:13:49, ahe wrote:
> Long line.

Done.

[Anton Muhin, 2012-10-29 18:19:22]

lgtm

if it makes tree green, it might be a good idea to submit, but do not forget to
address Peter's comments

https://chromiumcodereview.appspot.com/11267046/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/dart_backend/placeholder_collector.dart
(right):

https://chromiumcodereview.appspot.com/11267046/diff/4001/lib/compiler/implem...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:353:
assert(type !== null);
nit: != here and everywhere

[Roman, 2012-10-29 18:40:27]

https://chromiumcodereview.appspot.com/11267046/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/dart_backend/placeholder_collector.dart
(right):

https://chromiumcodereview.appspot.com/11267046/diff/4001/lib/compiler/implem...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:353:
assert(type !== null);
On 2012/10/29 18:19:22, Anton Muhin wrote:
> nit: != here and everywhere

Done.

[Roman, 2012-10-29 19:29:48]

I submitted the CL to make the buildbots green. I commented about 40 failing
tests, including all redirecting constructors, I'll fix them soon.
Also in cases when class A is empty and main code calls unresolved constructor
like 'new A.named()' class A does not get into instantiated classes and we don't
emit it.

Anton, Peter, if you have more comments, I'll be happy to address them tomorrow.